rfc:socket_getaddrinfo

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revision Previous revision
Next revision
Previous revision
rfc:socket_getaddrinfo [2016/08/11 21:44]
bp1222
rfc:socket_getaddrinfo [2017/09/22 13:28] (current)
Line 3: Line 3:
   * Date: 2016-08-08   * Date: 2016-08-08
   * Author: David Walker (dave@mudsite.com)   * Author: David Walker (dave@mudsite.com)
-  * Status: Under Discussion+  * Status: Implemented (PHP 7.2)
   * First Published at: http://wiki.php.net/rfc/socket_getaddrinfo   * First Published at: http://wiki.php.net/rfc/socket_getaddrinfo
  
 ===== Introduction ===== ===== Introduction =====
-This RFC targets a reported feature request in [[https://bugs.php.net/bug.php?id=72733|#72733]].  The request is that PHP expose the C level function getaddrinfo().  This is a missing nice piece to the current socket library.  When dealing with IP variable networks it would be beneficial to allow libc to tell us what methods of connecting/listening would be most appropriate given a set of hints.+This RFC targets a reported feature request in [[https://bugs.php.net/bug.php?id=72733|#72733]].  The request is that PHP expose the C level function getaddrinfo().  This is a missing nice piece to the current socket library.  When dealing with variable networks it would be beneficial to allow libc to tell us what methods of connecting/listening would be most appropriate given a set of hints.
  
-===== Proposals ===== +===== Proposal ===== 
-I'm starting this RFC with 2 proposed solutions, which are very similar, but I'm not sure which is preferable for implementation. +The implementation[[https://wiki.php.net/rfc/socket_getaddrinfo#references|[1]]] I'm proposing implements new functions.  ''socket_addrinfo_lookup()'' will return an array of resources, with each resource corresponding to each returned addrinfo.  The next two implemented methods ''socket_addrinfo_bind()'', and ''socket_addrinfo_connect()'', would be used to bind, or connect, to a given resource rather than make the user go through the process of creating the socket and connect/binding themselves.  The last, ``socket_addrinfo_explain`` is to convert the resource to an array for examination.
-==== Proposal 1 ==== +
-The implementation[[https://wiki.php.net/rfc/socket_getaddrinfo#references|[1]]] I'm proposing implements new socket_* functions.  ''socket_getaddrinfo()'' will return an array of resources, with each resource corresponding to each returned addrinfo.  The next two implemented methods ''socket_addrinfo_bind()'', and ''socket_addrinfo_connect()'', would be used to bind, or connect, to a given resource rather than make the user go through the process of creating the socket and connect/binding themselves.  The fourth function is a free'r if you'd want to free the resources before end of script.  And the last to pull info from the addrinfo resource.+
 <file php> <file php>
-socket_getaddrinfo(string node[, mixed service, array hints]) : array+socket_addrinfo_lookup(string node[, mixed service, array hints]) : array
 socket_addrinfo_connect(resource $addrinfo) : resource socket_addrinfo_connect(resource $addrinfo) : resource
 socket_addrinfo_bind(resource $addrinfo) : resource socket_addrinfo_bind(resource $addrinfo) : resource
-socket_addrinfo(resource $addrinfo) : array +socket_addrinfo_explain(resource $addrinfo) : array
-socket_addrinfo_close(sockaddrresource sockaddr) : null+
 </file> </file>
  
 +IPv4 Example
 <file php> <file php>
 <?php <?php
-$addrinfo = socket_getaddrinfo('127.0.0.1', 2000, array('ai_family' => AI_INET, 'ai_socktype' => SOCK_STREAM));+$addrinfo = socket_addrinfo_lookup('localhost', 2000, array('ai_family' => AF_INET, 'ai_socktype' => SOCK_STREAM));
 $sockaddr = reset($addrinfo); $sockaddr = reset($addrinfo);
 if (!$sockaddr) die ("No Valid Socket Types"); if (!$sockaddr) die ("No Valid Socket Types");
 $sock = socket_addrinfo_bind($sockaddr); $sock = socket_addrinfo_bind($sockaddr);
 // ^^ $sock is a socket resource that is bound to 127.0.0.1:2000 using TCP/IP ready for reading // ^^ $sock is a socket resource that is bound to 127.0.0.1:2000 using TCP/IP ready for reading
-foreach ($addrinfo as $sockaddr) { + 
-    socket_addrinfo_close($sockaddr);+var_dump(socket_addrinfo_explain($sockaddr)); 
 +/* Outputs: 
 +array(5) { 
 +  ["ai_flags"]=> 
 +  int(0) 
 +  ["ai_family"]=> 
 +  int(2) 
 +  ["ai_socktype"]=> 
 +  int(1) 
 +  ["ai_protocol"]=> 
 +  int(6) 
 +  ["ai_addr"]=> 
 +  array(2) { 
 +    ["sin_port"]=> 
 +    int(2000) 
 +    ["sin_addr"]=> 
 +    string(9) "127.0.0.1" 
 +  }
 } }
 +*/
 </file> </file>
  
-**Pro** +IPv6 Example
-  * Doesn't change current functions +
-**Con** +
-  * Adds duplicative functions +
-  * Isn't very 'C' like in how it's used +
- +
-==== Proposal 2 ==== +
-This attempt [[https://wiki.php.net/rfc/socket_getaddrinfo#references|[2]]] is similar to the first, and tries to be a hybrid approach.  It alters the default signature of socket_(connect|bind) to change the second argument to mixed.  This method is the most C-like of the 3.  After playing with all three, this is my preferred, but changing default signatures is not always the best idea. +
- +
-<file php> +
-socket_getaddrinfo(string $node[, mixed $service, array $hints]) : array +
-socket_connect(resource $sock, mixed $address_or_addrinfo[, int $port = 0]) : bool +
-socket_bind(resource $sock, string $address_or_addrinfo[, int port = 0]) : bool +
-socket_addrinfo_close(resourece $addrinfo) : null +
-</file> +
 <file php> <file php>
 <?php <?php
-$addrinfo = socket_getaddrinfo('127.0.0.1', 2000, array('ai_family' => AI_INET, 'ai_socktype' => SOCK_STREAM));+$addrinfo = socket_addrinfo_lookup('localhost', 2000, array('ai_family' => AF_INET6, 'ai_socktype' => SOCK_STREAM));
 $sockaddr = reset($addrinfo); $sockaddr = reset($addrinfo);
 if (!$sockaddr) die ("No Valid Socket Types"); if (!$sockaddr) die ("No Valid Socket Types");
-$sock = socket_create($sockaddr['ai_family'], $sockaddr['ai_socktype'], $sockaddr['ai_protocol']); +$sock = socket_addrinfo_bind($sockaddr); 
-$sock = socket_bind($sock, $sockaddr); +// ^^ $sock is a socket resource that is bound to [::1]:2000 using TCP/IP ready for reading 
-// ^^ $sock is a socket resource that is bound to 127.0.0.1:2000 using TCP/IP ready for reading + 
-foreach ($addrinfo as $sockaddr) { +var_dump(socket_addrinfo_explain($sockaddr)); 
-    socket_addrinfo_close($sockaddr);+/* Outputs: 
 +array(5) { 
 +  ["ai_flags"]=> 
 +  int(0) 
 +  ["ai_family"]=> 
 +  int(10) 
 +  ["ai_socktype"]=> 
 +  int(1) 
 +  ["ai_protocol"]=> 
 +  int(6) 
 +  ["ai_addr"]=> 
 +  array(2) { 
 +    ["sin6_port"]=> 
 +    int(2000) 
 +    ["sin6_addr"]=> 
 +    string(3) "::1" 
 +  }
 } }
 +*/
 </file> </file>
- 
-**Pro** 
-  * Used much more like how C implements socket()/bind()/connect() 
-**Con** 
-  * Changes default signatures of socket_bind()/socket_connect() 
  
 ===== Backward Incompatible Changes ===== ===== Backward Incompatible Changes =====
-New functionality; BC problems in changing default socket function signatures for Proposal 2.  Although code that exists today ought not to have BC issues.+New functionality; no BC issues.
  
 ===== Proposed PHP Version(s) ===== ===== Proposed PHP Version(s) =====
Line 85: Line 98:
 ==== New Constants ==== ==== New Constants ====
 Exposing the AI_* family of constants. Exposing the AI_* family of constants.
- 
-===== Open Issues ===== 
  
 ===== Proposed Voting Choices ===== ===== Proposed Voting Choices =====
-Vote to implement the new functions, would require a 2/3 majority.+Vote to implement the new functionality, would require a 2/3 majority. 
 +<doodle title="Implement socket_getaddrinfo family" auth="bp1222" voteType="single" closed="true"> 
 +   * Yes 
 +   * No 
 +</doodle> 
 +Vote Start: 2016-08-24 15:23 UTC 
 + 
 +Vote End:   2016-08-31 23:59 UTC
  
 ===== Implementation ===== ===== Implementation =====
 +
 +  - merged into master (i.e. pre 7.2)
 +  - https://github.com/php/php-src/commit/d59af68f
 +  - https://github.com/php/php-src/commit/750f3d3f
 +  - a link to the PHP manual entry for the feature
  
 ===== References ===== ===== References =====
-  * [1] - [[https://github.com/php/php-src/compare/master...bp1222:fix-72733|Proposed #1 Implementation]] +  * [1] - [[https://github.com/php/php-src/pull/2078|Proposed Implementation]]
-  * [2] - [[https://github.com/php/php-src/compare/master...bp1222:fix3-72733|Proposed #2 Implementation]]+
rfc/socket_getaddrinfo.1470951856.txt.gz · Last modified: 2017/09/22 13:28 (external edit)