rfc:same-site-cookie

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revisionPrevious revision
Next revision		Previous revision
Next revisionBoth sides next revision
rfc:same-site-cookie [2017/07/24 08:45] – f.bosch_genkgo.nlrfc:same-site-cookie [2018/09/20 11:04] – Add links to implementation and documentation cmb
Line 4: Line 4:
   * Author of RFC and creator of PR: Frederik Bosch, f.bosch@genkgo.nl   * Author of RFC and creator of PR: Frederik Bosch, f.bosch@genkgo.nl
   * Author of original patch: xistence at 0x90 dot nl   * Author of original patch: xistence at 0x90 dot nl
-  * Status: Draft+  * Status: Implemented (PHP 7.3 via commit [[http://git.php.net/?p=php-src.git;a=commit;h=08b9310|08b9310]] and [[http://git.php.net/?p=php-src.git;a=commit;h=2b58ab2|2b58ab2]].)
   * First Published at: https://wiki.php.net/rfc/same-site-cookie   * First Published at: https://wiki.php.net/rfc/same-site-cookie
  
Line 66: Line 66:
  
 <code php> <code php>
-bool setcookie ( string $name [, string $value = "" [, int $expire = 0 [, string $path = "" [, string $domain = "" [, bool $secure = false [, bool $httponly = false]]]]]] ) +bool setrawcookie ( string $name [, string $value = "" [, int $expire = 0 [, string $path = "" [, string $domain = "" [, bool $secure = false [, bool $httponly = false]]]]]] ) 
-bool setcookie ( string $name [, string $value = "" [, int $expire = 0 [, array $options ]]] )+bool setrawcookie ( string $name [, string $value = "" [, int $expire = 0 [, array $options ]]] )
 </code> </code>
  
Line 80: Line 80:
  
 <code php> <code php>
 +void session_set_cookie_params ( int $lifetime [, string $path [, string $domain [, bool $secure = false [, bool $httponly = false ]]]] )
 void session_set_cookie_params ( int $lifetime [, array $options ] ) void session_set_cookie_params ( int $lifetime [, array $options ] )
 </code> </code>
Line 111: Line 112:
  
 ===== Proposed PHP Version(s) ===== ===== Proposed PHP Version(s) =====
-next PHP 7.x+Next PHP 7.x. Since deadlines have passed for 7.2, this will be 7.3.
  
 ===== RFC Impact ===== ===== RFC Impact =====
Line 126: Line 127:
  
 ===== Proposed Voting Choices ===== ===== Proposed Voting Choices =====
-This RFC requires a 50%+1 majority. When opening the RFC there will be two questions.+This RFC requires a 50%+1 majority. If both questions pass, only the one with most votes will be implemented. 
 + 
 + 
 +=== First implementation suggestion === 
 + 
 + 
 +<doodle title="Add samesite argument to setcookie, setrawcookie and session_set_cookie_params functions?" auth="f.bosch@genkgo.nl" voteType="single" closed="true"> 
 +   * Yes 
 +   * No 
 +</doodle>
  
-1. Add samesite argument to setcookie, setrawcookie and session_set_cookie_params functions.+=== Second implementation suggestion ===
  
-2. Allow setcookie, setrawcookie and session_set_cookie_params to accept an array of options, with the possible options being path, domain, secure, httponly and samesite.+<doodle title="Allow setcookie, setrawcookie and session_set_cookie_params to accept an array of options as fourth/second parameter, with the possible options being path, domain, secure, httponly and samesite?" auth="f.bosch@genkgo.nl" voteType="single" closed="true"> 
 +   * Yes 
 +   * No 
 +</doodle>
  
 ===== Patches and Tests ===== ===== Patches and Tests =====
-  * [[https://github.com/php/php-src/pull/2613|Github PR #2613]]+  * [[https://github.com/php/php-src/pull/2613|Github PR #2613 containing the additional argument solution]] 
 +  * Github PR with the array of options solution will be created when this RFC gets accepted 
 +  * Implemented via [[http://git.php.net/?p=php-src.git;a=commit;h=08b9310]] and [[http://git.php.net/?p=php-src.git;a=commit;h=2b58ab2]] 
 +  * Documented via [[http://svn.php.net/viewvc?view=revision&revision=345661]]
  
 ===== References ===== ===== References =====
rfc/same-site-cookie.txt · Last modified: 2022/11/21 11:07 by girgias

Page Tools