rfc:permanent_hash_ext

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revisionPrevious revision
Next revision		Previous revision
Last revisionBoth sides next revision
rfc:permanent_hash_ext [2018/09/04 09:07] – kallerfc:permanent_hash_ext [2018/10/03 06:39] – kalle
Line 1: Line 1:
 ====== RFC: Always available hash extension  ====== ====== RFC: Always available hash extension  ======
   * Version: 1.0   * Version: 1.0
-  * Date: 04/09-2018+  * Date: 2018-09-04
   * Author: Kalle Sommer Nielsen, kalle@php.net   * Author: Kalle Sommer Nielsen, kalle@php.net
-  * Status: Discussion+  * Status: Implemented
   * First Published at: http://wiki.php.net/rfc/permanent_hash_ext   * First Published at: http://wiki.php.net/rfc/permanent_hash_ext
  
Line 10: Line 10:
  
 ===== Proposal ===== ===== Proposal =====
-The hash extensions provides a very rich utility with many hashing algorithms which is extremely useful in modern day applications, not only in userland code but also very much in internals.+The hash extension provides a very rich utility with many hashing algorithms which is extremely useful in modern day applications, not only in userland code but also very much in internals.
  
 After a recent discussion on Github[1], Johannes proposed that the hash extension should be treated as special extension which cannot be disabled. After a recent discussion on Github[1], Johannes proposed that the hash extension should be treated as special extension which cannot be disabled.
Line 16: Line 16:
 ===== Backward Incompatible Changes ===== ===== Backward Incompatible Changes =====
  
-Build configurations that contain `--with-hash` will have to be updated, as the argument will cease to exists. The `--with-mhash` argument will continue to stay.+Build configurations that contain `--enable-hash` will have to be updated, as the argument will cease to exists. The `--with-mhash` argument will continue to stay.
  
 ===== Proposed PHP Version(s) ===== ===== Proposed PHP Version(s) =====
Line 33: Line 33:
 Any already existing userland code will continue to work as before. Userland may remove calls to `extension_loaded('hash')` as they will now always return true. Any already existing userland code will continue to work as before. Userland may remove calls to `extension_loaded('hash')` as they will now always return true.
  
-The hash extension does not have any external dependencies, so this will not add any more depdendencies for a minimal build of PHP.+The hash extension does not have any external dependencies, so this will not add any more dependencies for a minimal build of PHP.
  
 ===== Proposed Voting Choices ===== ===== Proposed Voting Choices =====
  
 Since this touches a major component in the php-src source, the voting will require a 2/3 majority to pass. Since this touches a major component in the php-src source, the voting will require a 2/3 majority to pass.
 +
 +===== Vote =====
 +
 +As this is a language change, a 2/3 majority is required.
 +
 +<doodle title="Make the hash extension always available as described in this RFC?" auth="kalle" voteType="single" closed="true">
 +   * Yes
 +   * No
 +</doodle>
  
 ===== Patches and Tests ===== ===== Patches and Tests =====
  
-If the voting passes, a patch to alter the extension build configurations for Windows and Unix will be committed.+  * Patch: https://gist.github.com/KalleZ/f9e50b36db608478617868057d2b9e77
  
 ===== References ===== ===== References =====
  
   * [1] https://github.com/php/php-src/commit/d6e81f0bfd0cb90586dd83d4fd47a4302605261a#commitcomment-29654178   * [1] https://github.com/php/php-src/commit/d6e81f0bfd0cb90586dd83d4fd47a4302605261a#commitcomment-29654178
rfc/permanent_hash_ext.txt · Last modified: 2018/11/22 19:17 by cmb

Page Tools