Differences

This shows you the differences between two versions of the page.

--- rfc:jsond [2015/01/02 15:54] – bukka
+++ rfc:jsond [2017/09/22 13:28] (current) – external edit 127.0.0.1
@@ Line 1: / Line 1: @@
 ====== PHP RFC: Replacing current json extension with jsond ======
-  * Version: 0.1
+  * Version: 0.2
   * Date: 2015-01-01
   * Author: Jakub Zelenka, bukka@php.net
-  * Status: Draft
+  * Status: Implemented (PHP 7.0)
 ===== Introduction =====
-The Parser for the current json extension does not have a free license which is a problem for many Linux distros. The extension code is also very old which makes it difficult for further improvements. There also are some implementation decisions that makes the performance worse than it should be
+The current Json Parser in the json extension does not have a free license which is a problem for many Linux distros. This has been referenced at [[https://bugs.php.net/63520|Bug #63520]]. That results in not packaging json extension in the many Linux distributions.
+The extension code is very old and without a maintainer which makes it difficult for further improvements. There also are some implementation decisions that makes the performance worse than it should be (see benchmarks).
 ===== Proposal =====
-The proposal is to replace current json extension with code based on the PECL jsond extension (it's not exactly the same as there are some modification for PHP 7).
+The proposal is to replace the current json extension with code that is based on the PECL jsond extension (it's not exactly the same code as there are some modifications for PHP 7).
 ===== Backward Incompatible Changes =====
-  * Rejected ECMA-404 incompatible number formats
+  * Rejected ECMA-404 and RFC 7159 incompatible number formats in json_decode string
-    * top level (PHP json_decode check): <code>07</code>, <code>0xff</code>, <code>.1</code>, <code>-.1</code>
+    * top level (PHP json_decode check): 07, 0xff, .1, -.1
-    * all (JSON_Parser): <code>[1.]</code>, <code>[1.e1]</code>
+    * all (JSON_Parser): [1.], [1.e1]
+The first part (top level) is caused by different handling of integer and double because it's not handled by JSON_Parser. This is clearly a bug.
+The second part is happening for all numbers. However it's not valid by the RFC 7159 as it says in  https://tools.ietf.org/html/rfc7159#section-6 :
+<code>
+number = [ minus ] int [ frac ] [ exp ]
+decimal-point = %x2E       ; .
+digit1-9 = %x31-39         ; 1-9
+e = %x65 / %x45            ; e E
+exp = e [ minus / plus ] 1*DIGIT
+frac = decimal-point 1*DIGIT
+int = zero / ( digit1-9 *DIGIT )
+minus = %x2D               ; -
+plus = %x2B                ; +
+zero = %x30                ; 0
+</code>
+Please note the definition of frac that specifies that at least one digit after decimal point is required.
 ===== Proposed PHP Version(s) =====
@@ Line 25: / Line 46: @@
 ==== To Existing Extensions ====
-* removed JSON_parser.h header
+In addition to the backward incompatible changes for float number format the following internal changes have been done:
-* removed utf8_decode.h header
+  * removed JSON_parser.h header
-* error codes constants moved to php_json.h
+  * removed utf8_decode.h header
-  * <code>enum error_codes</code> renamed to <code>php_json_error_codes</code> (typedef)
+  * macro JSON_PARSER_DEFAULT_DEPTH renamed to PHP_JSON_PARSER_DEFAULT_DEPTH
-  * ext global `error_code` type changed from `int` to `php_json_error_codes`
+  * error codes constants moved to php_json.h
-- macro JSON_PARSER_DEFAULT_DEPTH renamed to PHP_JSON_PARSER_DEFAULT_DEPTH
+    * enum error_codes renamed to php_json_error_codes (typedef)
+    * ext global error_code type changed from int to php_json_error_codes
 ==== To Opcache ====
@@ Line 36: / Line 58: @@
 ==== New Constants ====
-New error <code>JSON_ERROR_UTF16</code> for invalid \uXXXX code (ill-formed surrogate pairs)
+None
 ===== Open Issues =====
-No
+None
-===== Unaffected PHP Functionality =====
-There should be no changes from the User space except the one described above
 ===== Future Scope =====
-Performance for encoder
+  * Improving performance for encoder and decoder
+  * Better error reporting (location of the error)
-===== Proposed Voting Choices =====
+===== Vote =====
-%+1 majority
+%+1 majority. The vote is a straight Yes/No vote.
+<doodle title="Should jsond based extension replace the current json extension in PHP 7?" auth="bukka" voteType="single" closed="true">
+   * Yes
+   * No
+</doodle>
+The vote started on 2015-01-26 at 17:00 UTC and ended on 2015-02-01 at 17:00 UTC.
 ===== Patches and Tests =====
-https://github.com/bukka/php-src/compare/jsond
+Pull request for master branch: https://github.com/php/php-src/pull/993
+The summary of the benchmarks is at https://github.com/bukka/php-jsond-bench/blob/master/reports/0001/summary.md. There also is a link for runs (measured data).
 ===== Implementation =====
-After the project is implemented, this section should contain
+After the project is implemented, this section will contain
-  - the version(s) it was merged to
+  - Merged to the master branch and will be released in PHP 7
-  - a link to the git commit(s)
-  - a link to the PHP manual entry for the feature
 ===== References =====
-...
+There is an old RFC for [[https://wiki.php.net/rfc/free-json-parser|free json parser]] that proposed jsonc as a replacement for json. There were some concerns about the compatibility and performance https://www.mail-archive.com/internals@lists.php.net/msg66658.html .
+Executed code showing the current non-conformant number parsing: http://3v4l.org/2D72Q
-===== Rejected Features =====
-Keep this updated with features that were discussed on the mail lists.

Differences

Page Tools