rfc:allow-abstract-function-override

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revisionPrevious revision
Next revision		Previous revision
Last revisionBoth sides next revision
rfc:allow-abstract-function-override [2017/03/01 02:07] – wesnetmorfc:allow-abstract-function-override [2017/05/24 15:45] – nikic
Line 3: Line 3:
   * Version: 0.1   * Version: 0.1
   * Date: 2017-03-01   * Date: 2017-03-01
-  * Author: @WesNetmo @ Twitter (has no internals knowledge) +  * Author: @WesNetmo @ Twitter 
-  * Status: Under Discussion+  * Status: Implemented (in PHP 7.2)
   * First Published at: https://wiki.php.net/rfc/allow-abstract-function-override   * First Published at: https://wiki.php.net/rfc/allow-abstract-function-override
  
Line 49: Line 49:
  
 // This phpdoc syntax has quirks in phpdocumentor // This phpdoc syntax has quirks in phpdocumentor
-// apigen and phpstorm, and it's almost unmanageable:+// apigen and phpstorm, and it's almost unmanageable 
 +// as phpdoc interpreters have poor multiline support 
 +// (imagine documenting all the parameters, the return 
 +// type, all the throws...):
 /** @method B getOrigin() */ /** @method B getOrigin() */
 abstract class BProxy extends AProxy implements B{ abstract class BProxy extends AProxy implements B{
Line 60: Line 63:
 </code> </code>
  
-And, obviously, it will come in handy when PHP will support a full-featured type variance.+And, obviously, it will gain more uses when PHP will support a full-featured type variance.
  
 ===== Backward Incompatible Changes ===== ===== Backward Incompatible Changes =====
Line 72: Line 75:
 ===== Voting ===== ===== Voting =====
  
-Will require 2/3 majority to pass.+2/3 majority required. 
 + 
 +<doodle title="Accept abstract function override?" auth="WesNetmo" voteType="single" closed="true"> 
 +   * Yes 
 +   * No 
 +</doodle>
  
 ===== Patches and Tests ===== ===== Patches and Tests =====
  
-N/A+Pull request to handle the change: https://github.com/php/php-src/pull/2531
  
 ===== References ===== ===== References =====
  
-[[http://externals.io/thread/573|Discussion on externals.io]]+[[https://externals.io/thread/735|Discussion on externals.io]]
rfc/allow-abstract-function-override.txt · Last modified: 2017/09/22 13:28 by 127.0.0.1

Page Tools