rfc:var-export-array-syntax

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revisionPrevious revision
Next revision		Previous revision
Next revisionBoth sides next revision
rfc:var-export-array-syntax [2020/03/29 17:48] – googleguyrfc:var-export-array-syntax [2020/03/30 16:02] – googleguy
Line 3: Line 3:
   * Date: 2020-03-29   * Date: 2020-03-29
   * Author: Sherif Ramadan, googleguy@php.net   * Author: Sherif Ramadan, googleguy@php.net
-  * Status: Draft+  * Status: Under Discussion
   * First Published at: http://wiki.php.net/rfc/var-export-array-syntax   * First Published at: http://wiki.php.net/rfc/var-export-array-syntax
  
Line 12: Line 12:
  
 ===== Proposal ===== ===== Proposal =====
-Instead of <code php>array(1, 2, 3)</code> ''var_export()'' would produce <code php>[1, 2, 3]</code>+Instead of 
 + 
 +<code php>array(1, 2, 3)</code> 
 + 
 +''var_export()'' would produce 
 + 
 +<code php>[1, 2, 3]</code> 
 + 
 +This will effect things like ''stdClass'' and ''set_state'' as well since they are cast to objects from array literals and they use the long-form array syntax above. 
 + 
 +So the following changes are also in effect: 
 + 
 +<code php> 
 +$obj = new stdClass; 
 +$obj->foo = "bar"; 
 +$obj->baz = "quix"; 
 + 
 +var_export($obj); 
 + 
 +/* 
 +Gives us: 
 +(object) array( 
 +   'foo' => 'bar', 
 +   'baz' => 'quix', 
 +) 
 + 
 +With the new change it would be 
 + 
 +(object) [ 
 +   'foo' => 'bar', 
 +   'baz' => 'quix', 
 +] 
 +*/ 
 +</code> 
 + 
 +The same happens for classes: 
 + 
 +<code php> 
 +class Foo { 
 +    public $bar = "baz"; 
 +} 
 + 
 +var_export(new Foo); 
 + 
 +/* 
 +Gives us: 
 +Foo::__set_state(array( 
 +   'bar' => 'baz', 
 +)) 
 + 
 +With the changes it would be: 
 +Foo::__set_state([ 
 +   'bar' => 'baz', 
 +]) 
 +*/ 
 +</code>
  
 ===== Backward Incompatible Changes ===== ===== Backward Incompatible Changes =====
 There shouldn't be any backwards incompatible changes as ''var_export()'' will continue to produce valid PHP code such that ''var_export()'' to PHP and PHP back to ''var_export()'' will continue to work as expected. The syntax changes are all forwards compatible as of PHP 5.4 so we shouldn't see any issues here. There shouldn't be any backwards incompatible changes as ''var_export()'' will continue to produce valid PHP code such that ''var_export()'' to PHP and PHP back to ''var_export()'' will continue to work as expected. The syntax changes are all forwards compatible as of PHP 5.4 so we shouldn't see any issues here.
 +
 +However, there are some tests that test the output of ''var_export'', though I view this as a broken test more than I do a BC change. I liken this to a test which uses the value of a constant like ''E_ALL'' rather than just using the constant itself in testing that the constant works. Why not just test that ''var_export'' gives you back an array rather than test its output? It's all valid PHP code that we care about not the output itself. The output value, like the constant value, is subject to change. That's why we use it in the first place. To prevent change from effecting the test (constant).
 +
 +I hope that's clear.
 +
 +In the event that this RFC is voted through I will, however, be updating these tests.
  
 ===== Proposed PHP Version(s) ===== ===== Proposed PHP Version(s) =====
Line 39: Line 100:
  
 ===== Patches and Tests ===== ===== Patches and Tests =====
-The change only requires changing two lines in ''ext/standard/var.c'' (lines 530 and 540) to replace ''array ('' and '')'' with ''['' and '']''. See https://heap.space/xref/php-src/ext/standard/var.c?r=a9398056#530-540 for reference.+The change only requires changing two lines in ''ext/standard/var.c'' (lines 530 and 540) to replace ''array ('' and '')'' with ''['' and '']''. 
 + 
 +See https://heap.space/xref/php-src/ext/standard/var.c?r=a9398056#530-540 for reference.
  
 ===== Implementation ===== ===== Implementation =====
Line 45: Line 108:
 ===== References ===== ===== References =====
 https://heap.space/xref/php-src/ext/standard/var.c?r=a9398056#530-540 https://heap.space/xref/php-src/ext/standard/var.c?r=a9398056#530-540
 +
 +https://news-web.php.net/php.internals/109415
  
 ===== Rejected Features ===== ===== Rejected Features =====
  
rfc/var-export-array-syntax.txt · Last modified: 2020/04/10 09:24 by guilliamxavier

Page Tools