This is an old revision of the document!
PHP RFC: Improve uniqid() uniqueness
- Version: 0.9
- Date Created: 2016-09-12
- Date Modified: 2016-09-12
- Author: Yasuo Ohgaki email@example.com
- Status: Under
- First Published at: http://wiki.php.net/rfc/uniqid
uniqid() is supposed to create unique ID based on time. Current implementation does not make sure uniqueness of result because it relies on system time.
Why it is not unique
Current implementation uses usleep(1) to generate unique ID based on microtime(). Most systems adjust system time by NTP or similar. System time is adjusted by magnitude of milliseconds or even seconds constantly. Therefore, usleep(1) does not guarantee uniqueness of return value on the same process/thread nor other process/thread.
Poor entropy source
Current implementation uses php_combined_lcd() and 9 digits float value as “more entropy”. php_combined_lcg() is weak source of entropy. Since we have php_random_bytes() as better entropy source, it is preferred to use stronger entropy source.
- Current entropy range: About 1 billion
- Proposed entropy range: 2^50. About 1048567 billions
- Enable “more entropy” option by default.
- Use php_random_bytes() as entropy source.
Note on usage
Users should never use uniqid() for any crypt related purposes even with this change. uniqid() does not provide crypt secure random value. Users should use random_bytes() for crypt purposes.
Backward Incompatible Changes
Almost all uniqid() usages do not care about return value chars nor length. Therefore, BC will be minimum.
Windows CYGWIN environment requires “more entropy” always and default “more entropy” optione for CYGWIN is TRUE by default. It raises E_WARNING when “more entropy” option is FALSE.
Default return value length
- Return value is longer than current default. (13 -> 23 chars)
Current implementation output example:
$ php -r 'var_dump(uniqid(), uniqid(“”, TRUE));' string(13) “57d60ed86d339” string(23) “57d60ed86d33c9.09289803”
Chars used by "more entropy"
- More entropy uses digits and alphabets.
Proposed implementation output example:
$ ./php-bin -r 'var_dump(uniqid(“”, FALSE), uniqid(“”, TRUE));' string(13) “57d60f6bc6637” string(23) “57d60f6bc6654mb7167bnou”
Proposed PHP Version(s)
Next PHP (Currently PHP 7.2)
To Existing Extensions
Make sure there are no open issues when the vote starts!
Unaffected PHP Functionality
Anything but uniqid() is affected.
Proposed Voting Choices
State whether this project requires a 2/3 majority (see voting)
Patches and Tests
After the project is implemented, this section should contain
- the version(s) it was merged to
- a link to the git commit(s)
- a link to the PHP manual entry for the feature
Links to external references, discussions or RFCs
Keep this updated with features that were discussed on the mail lists.