rfc:shorter_attribute_syntax

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revision Previous revision
Next revision
Previous revision
rfc:shorter_attribute_syntax [2020/06/17 23:56]
theodorejb Open voting
rfc:shorter_attribute_syntax [2020/08/12 15:56]
theodorejb Update nested syntax for #[] - I think this was a relic of the idea to strip all leading hashes
Line 2: Line 2:
   * Date: 2020-06-03   * Date: 2020-06-03
   * Author: Theodore Brown <theodorejb@outlook.com>, Martin Schröder   * Author: Theodore Brown <theodorejb@outlook.com>, Martin Schröder
-  * Status: Under Discussion+  * Status: Implemented
   * Discussion: https://externals.io/message/110355   * Discussion: https://externals.io/message/110355
   * Target Version: PHP 8.0   * Target Version: PHP 8.0
-  * Implementation for ''@@'': https://github.com/koolkode/php-src/pull/+  * Implementation: https://github.com/php/php-src/pull/5796
-  * Implementation for ''#[]'': https://github.com/koolkode/php-src/pull/5+
  
 ===== Introduction ===== ===== Introduction =====
Line 199: Line 198:
     #[JoinTable(     #[JoinTable(
         "User_Group",         "User_Group",
-        #JoinColumn("User_id", "id"), +        #[JoinColumn("User_id", "id")]
-        #JoinColumn("Group_id", "id"),+        #[JoinColumn("Group_id", "id")],
     )]     )]
     private $groups;     private $groups;
Line 311: Line 310:
 ===== Vote ===== ===== Vote =====
  
-Voting started on 2020-06-17 and will end on 2020-07-01.+Voting started on 2020-06-17 and ended on 2020-07-01.
  
 ==== Primary vote ==== ==== Primary vote ====
  
-<doodle title="Are you okay with re-voting on the attribute syntax for PHP 8.0?" auth="theodorejb" voteType="single" closed="false">+<doodle title="Are you okay with re-voting on the attribute syntax for PHP 8.0?" auth="theodorejb" voteType="single" closed="true">
    * Yes    * Yes
    * No    * No
Line 326: Line 325:
 === First choice === === First choice ===
  
-<doodle title="Attribute syntax 1st choice" auth="theodorejb" voteType="single" closed="false">+<doodle title="Attribute syntax choice #1" auth="theodorejb" voteType="single" closed="true">
    * @@    * @@
    * #[]    * #[]
Line 334: Line 333:
 === Second choice === === Second choice ===
  
-<doodle title="Attribute syntax 2nd choice" auth="theodorejb" voteType="single" closed="false">+<doodle title="Attribute syntax choice #2" auth="theodorejb" voteType="single" closed="true">
    * @@    * @@
    * #[]    * #[]
Line 342: Line 341:
 === Third choice === === Third choice ===
  
-<doodle title="Attribute syntax 3rd choice" auth="theodorejb" voteType="single" closed="false">+<doodle title="Attribute syntax choice #3" auth="theodorejb" voteType="single" closed="true">
    * @@    * @@
    * #[]    * #[]
rfc/shorter_attribute_syntax.txt · Last modified: 2020/08/12 15:56 by theodorejb