Differences

This shows you the differences between two versions of the page.

--- rfc:saner-numeric-strings [2020/07/15 16:27] – Align comments theodorejb
+++ rfc:saner-numeric-strings [2020/07/17 15:10] – Update status theodorejb
@@ Line 3: / Line 3: @@
   * Date: 2020-06-28
   * Author: George Peter Banyard <girgias@php.net>
-  * Status: Under Discussion
+  * Status: Voting
   * First Published at: http://wiki.php.net/rfc/saner-numeric-strings
   * Implementation: https://github.com/php/php-src/pull/5762
@@ Line 136: / Line 136: @@
 Unify the various numeric string modes into a single concept: Numeric characters only with both leading and trailing whitespace allowed. Any other type of string is non-numeric and will throw <php>TypeError</php>s when used in a numeric context.
-This means, all strings which currently emit the <php>E_NOTICE</php> “A non well formed numeric value encountered” will de reclassified into the <php>E_WARNING</php> “A non-numeric value encountered” //except// if the leading-numeric string contained only trailing whitespace. And the various cases which currently emit an <php>E_WARNING</php> will be promoted to <php>TypeError</php>s.
+This means, all strings which currently emit the <php>E_NOTICE</php> “A non well formed numeric value encountered” will be reclassified into the <php>E_WARNING</php> “A non-numeric value encountered” //except// if the leading-numeric string contained only trailing whitespace. And the various cases which currently emit an <php>E_WARNING</php> will be promoted to <php>TypeError</php>s.
 One exception to this are type declarations as they only accept proper numeric strings, thus some <php>E_NOTICE</php> will result in a <php>TypeError</php>. See below for an example.
@@ Line 226: / Line 226: @@
   * Warn on illegal offsets when used within <php>isset()</php> or <php>empty()</php>
-===== Proposed Voting Choices =====
+===== Vote =====
-Per the Voting RFC, there would be a single Yes/No vote requiring a 2/3 majority for the main proposal. A secondary Yes/No vote requiring a 50%+1 majority will decide whether float strings used as string offsets should continue to produce a warning (with different wording) instead of consistently becoming a TypeError.
+Per the Voting RFC, there is a single Yes/No vote requiring a 2/3 majority for the main proposal. A secondary Yes/No vote requiring a 50%+1 majority will decide whether float strings used as string offsets should continue to produce a warning (with different wording) instead of consistently becoming a TypeError.
+Primary vote:
+<doodle title="Accept Saner numeric string RFC proposal" auth="girgias" voteType="single" closed="false">
+   * Yes
+   * No
+</doodle>
+Secondary vote:
+<doodle title="Should valid float strings for string offsets remain a warning" auth="girgias" voteType="single" closed="false">
+   * Yes
+   * No
+</doodle>
 ===== Patches and Tests =====

Differences

Page Tools