Differences

This shows you the differences between two versions of the page.

--- rfc:resolve_symlinks [2021/03/27 17:52] – created rasmus
+++ rfc:resolve_symlinks [2021/03/27 18:03] (current) – rasmus
@@ Line 50: / Line 50: @@
 ;resolve_symlinks=On
 </code>
 ===== Backward Incompatible Changes =====
@@ Line 77: / Line 76: @@
 ===== Open Issues =====
+I think the main issue here is whether or not this is too niche. Nobody likes more config options and if you can count the number of sites that need this on one hand, perhaps this is better left as just a patch linked from this Draft RFC. Unfortunately there is no way to do this as an extension because the change needs to be made at a low level in //Zend/zend_virtual_cwd.c//.
 ===== Patches and Tests =====
@@ Line 85: / Line 85: @@
 I'll add a couple of simple tests as well and stub entries for php.ini-*
+One thing to note in the patch is the very last line with the change to //main/main.c//:
+<code c>
+CWDG(resolve_symlinks) = 1;
+</code>
+This is because during startup, before the config has been read, there are calls that depend on the //zend_virtual_cwd// functions and we want to make sure symlinks are followed during startup as this has nothing to do with Opcache entries.