rfc:readonly_and_immutable_properties

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revisionPrevious revision
Next revision		Previous revision
rfc:readonly_and_immutable_properties [2020/06/20 18:57] – formating andreromrfc:readonly_and_immutable_properties [2020/06/21 18:47] (current) – formating andrerom
Line 11: Line 11:
 ===== Introduction ===== ===== Introduction =====
  
-With the introduction of typed properties in PHP 7.4, properties have become far more powerful. However it is currently not possible to specify disconnected write vs read visibility for properties without having to resort to magic methods (getters and setters). This requires unnecessary boilerplate, makes usage less ergonomic and hurts performance. 
  
-This RFC resolves this issue by proposing: +**This is a early draft, currently looking for feedback on direction on what would make most sense to propose, especially if there is any point in even exploring using Attributes for the features covered here or not.**
-  - Language change to make it possibility to specify write visibility disconnected from read. Including defining immutable write visibility. +
-  - Readonly attribute for properties and classes (all properties), if #1 is accepted this is merely syntax sugar +
-  - Immutable attribute for properties and classes (all properties), if #1 is accepted this is merely syntax sugar+
  
 +With the introduction of typed properties in PHP 7.4, properties have become far more powerful. However it is currently not possible to specify disconnected write vs read visibility for properties, such as readonly, without having to resort to magic methods (getters and setters). For immutable semantic it's even more cumbersome. This requires unnecessary boilerplate, makes usage less ergonomic and hurts performance.
  
-//These three proposals will be offered as separate votes.//+This RFC resolves this issue by proposing a few options: 
 +  - Language approach: 
 +    - Change to make it possibility to specify write visibility disconnected from read. 
 +    - readonly keyword for write access, on property and class (implicit all properties) 
 +    - immutable keyword for write access, on property and class (implicit all properties) 
 +  - Attribute approach: 
 +    - Readonly attribute for properties, if #1.1/1.2 is accepted this is merely syntax sugar. 
 +    - Immutable attribute for properties, if #1.3 is accepted this is merely syntax sugar
  
  
Line 28: Line 32:
     private int $id;     private int $id;
     private string $name;     private string $name;
-    +
     public function __construct(int $id, string $name) {     public function __construct(int $id, string $name) {
         $this->id = $id;         $this->id = $id;
         $this->name = $name;         $this->name = $name;
     }     }
-    +
     public function __get($property)     public function __get($property)
     {     {
Line 42: Line 46:
         throw new PropertyNotFoundException($property, static::class);         throw new PropertyNotFoundException($property, static::class);
     }     }
-    +
     public function __set($property, $value)     public function __set($property, $value)
     {     {
Line 51: Line 55:
         throw new PropertyNotFoundException($property, static::class);         throw new PropertyNotFoundException($property, static::class);
     }     }
-    +
     public function __isset($property)     public function __isset($property)
     {     {
         return property_exists($this, $property);         return property_exists($this, $property);
     }     }
- 
  
     public function __unset($property)     public function __unset($property)
Line 71: Line 74:
     <<Readonly>>     <<Readonly>>
     public int $id;     public int $id;
-    +
     <<Readonly>>     <<Readonly>>
     public string $name;     public string $name;
-    + 
 +    public function __construct(int $id, string $name) { 
 +        $this->id = $id; 
 +        $this->name = $name; 
 +    } 
 +} 
 +</code> 
 + 
 + 
 +or just 
 + 
 +<code php> 
 +<<Readonly>> 
 +class User { 
 +    public int $id; 
 +    public string $name; 
     public function __construct(int $id, string $name) {     public function __construct(int $id, string $name) {
         $this->id = $id;         $this->id = $id;
Line 89: Line 108:
 ==== Readonly ==== ==== Readonly ====
  
-This RFC differs from [[rfc:readonly_properties|Readonly properties]] (2014, withdrawn) by instead using the recently accepted Attribute language feature for annotating Readonly properties. As done in Rust, and in user land annotations in many PHP frameworks.+This RFC aligns with [[rfc:readonly_properties|Readonly properties]] (2014, Withdrawn).
  
  
Line 95: Line 114:
  
  
-This RFC differs from[[rfc:immutability|Immutability]] (2018, stale) by instead using the recently accepted Attribute language feature for annotating Immutable properties. Aligning with Readonly proposal within this RFC.+This RFC aligns with [[rfc:immutability|Immutability]] (2018, Stale).
  
-This RFC does __not__ align with the semantics of the recent [[rfc:write_once_properties|Write once properties]], which is targeting a different problem.+This RFC does __not__ align with the semantics of the recent [[rfc:write_once_properties|Write once properties]] (2020, Declined), which is targeting a different problem.
  
  
Line 103: Line 122:
  
  
-This RFC does not try to solve as wider use case as the different iterations of [[rfc:propertygetsetsyntax-v1.2|Property Accessors Syntax]].+This RFC does not try to solve as wide use case as the different iterations of [[rfc:propertygetsetsyntax-v1.2|Property Accessors Syntax]] does.
  
-It's of this author's opinion that property type hinting and accessors where the two main obstacles to previous attempts at adding readonly semantics to PHP properties back in 2012-2014. And while readonly is rather hard to do in a clean way in PHP today, most other use cases offered by Accessors can be accomplished by plain PHP methods. Finally, Accessors overcomplicates readonly use case, and does not solve the needs for immutable property semantics. +However: 
- +- Accessors overcomplicates readonly, and does not offer solutions to immutability 
-Thus the author of this RFC believes what is proposed here should be done before any proposal for Accessors is re-considered, as anything here can be made syntax sugar for Accessors, if it ever gets accepted.+- There seems to be a higher need in the community for readonly and immutable semantics 
 +- Everything Accessors offers beyond disconnected read and write visibility for properties, can easily be done with plain methods. The same is not true for readonly and immutable semantics as shown in the introduction.
  
  
 ===== Proposal ===== ===== Proposal =====
  
-==== 1. Language ability to set property visibility for write access ====+==== Common semantics ==== 
 + 
 +== References == 
 + 
 +Attempting to pass a property value outside of allowed writable scope as a reference, results in an error. 
 + 
 + 
 +==== 1. Language Approach ==== 
 + 
 + 
 +=== 1.1 Language ability to set property visibility separately for write access ===
  
-This proposal adds support for runtime-enforced write visibility for declared properties. The following example illustrates the basic syntax:+This proposal adds support for enforced write visibility checks for declared properties. The following example illustrates the basic syntax:
  
 <code php> <code php>
Line 120: Line 150:
     // Property is readonly in protected and public scope     // Property is readonly in protected and public scope
     public:private int $id;     public:private int $id;
-    +
     // Property is readonly in public scope     // Property is readonly in public scope
     public:protected string $name;     public:protected string $name;
          
 +    // Property is write-only in public and protected scope
 +    private:public string $newName;
 +
     public function __construct(int $id, string $name) {     public function __construct(int $id, string $name) {
         $this->id = $id;         $this->id = $id;
Line 131: Line 164:
 </code> </code>
  
 +The format is "<read_visibility>:<write_visibility>", and if you omit the last visibility value you will like before implicit set both read and write visibility at once _(unless other future keywords or attributes states otherwise).
  
  
-== References ==+== Reflection ==
  
-Attempting to pass a property value outside of allowed scope as reference, is an error.+When using reflection, methods such as ''ReflectionProperty::setAccessible()'' will work as before, it will implicit set visibility for both read and write.
  
 +However with this proposal the following existing methods will represent read visibility for cases where it differs:
 +- ''ReflectionProperty::isPrivate()''
 +- ''ReflectionProperty::isProtected()''
 +- ''ReflectionProperty::isPublic()''
  
-//TODO: Cover how visibility is manipulated with reflection//+And for checking separate write visibility the following methods may be used: 
 +- ''ReflectionProperty::isWritePrivate'' — Checks if property is writable in private 
 +- ''ReflectionProperty::isWriteProtected'' — Checks if property is writable in protected 
 +- ''ReflectionProperty::isWritePublic'' — Checks if property is writable in public
  
  
-=== 1.1. Language ability to set immutable property visibility for write access ===+''Reflection::getModifiers()'' and ''Reflection::getModifierNames()'' will need adaption too, and proposal is to adapt it so ''getModifierNames()'' continues to return the visibility as specified, meaning it may now return for instance ''public:protected'' as one of the strings returned.
  
-This proposal adds support for runtime-enforced immutable write visibility for declared properties. The following example illustrates the basic syntax:+//TODO: Expand this with modifier ints representing all variations and their names// 
 + 
 +=== 1.2 readonly keyword === 
 + 
 +This proposal adds support for runtime-enforced readonly write visibility for declared properties. The following example illustrates the basic syntax:
  
 <code php> <code php>
 class User { class User {
-    // Property is immutable, can only be written to in __construct in private scope +    // Property is readonly, and can only be written to in protected scope 
-    public:private immutable string $id;+    public readonly int $id;
          
-    // Property is immutable, can only be written to in __construct in protected scope +    // Property is readonly, and can only be written to in private scope 
-    public immutable string $email;+    protected readonly string $name; 
 + 
 +    // [assuming 1.1 is accepted] Invalid declaration (visibility is already stating property is readonly) 
 +    public:private readonly string $email; 
 + 
 +    public function __construct(int $id, string $name) { 
 +        $this->id = $id; 
 +        $this->name = $name; 
 +    } 
 +} 
 +</code> 
 + 
 +Keyword can also be set on class level, implicit setting it on all fields unless they have their own immutable attribute: 
 + 
 +<code php> 
 +readonly class User { 
 +    // Property is readonly, and can only be written to in protected scope 
 +    public int $id;
          
 +    // Property is readonly, and can only be written to in private scope
 +    protected string $name;
 +
 +    // [assuming 1.1 is accepted] Invalid declaration (visibility is already stating property is readonly)
 +    public:private string $email;
 +
 +    public function __construct(int $id, string $name) {
 +        $this->id = $id;
 +        $this->name = $name;
 +    }
 +}
 +</code>
 +
 +
 +== Readonly semantics ==
 +
 +An readonly property may only be written to in scope lower than what is define as its read+write visibility, so if visibility is public, it may only be written to in protected scope.
 +
 +
 +== Reflection ==
 +
 +When using reflection, methods such as ''ReflectionProperty::setAccessible()'' will work as before, it will implicit disable readonly flag.
 +
 +Furthermore the following method is proposed added to be able to detect readonly properties:
 +- ''ReflectionProperty::isReadonly()''
 +
 +
 +''Reflection::getModifiers()'' and ''Reflection::getModifierNames()'' will need adaption too to add int and keywords for "readonly".
 +
 +//TODO: Expand this with specific modifier int for "readonly"//
 +
 +
 +=== 1.3 immutable keyword ===
 +
 +This proposal adds support for runtime-enforced immutable write visibility for declared properties. The following example illustrates the basic syntax:
 +
 +<code php>
 +class User {
 +    // Property is immutable, can only be written to in __construct in protected scope
 +    public immutable int $id;
 +
 +    // [assuming 1.1 is accepted] Property is immutable, can only be written to in __construct in private scope
 +    public:private immutable string $email;
 +
     public function __construct(int $id, string $email) {     public function __construct(int $id, string $email) {
         $this->id = $id;         $this->id = $id;
Line 160: Line 266:
 </code> </code>
  
 +Keyword can also be set on class level, implicit setting it on all fields unless they have their own readonly attribute:
  
-//TODO: There should perhaps be a 1.B proposal here so 1. and 1.1 is only exposed via reflection for 2. and 3. use, but kept out of the language  //+<code php> 
 +immutable class User { 
 +    // Property is immutable, can only be written to in during construction in protected scope 
 +    public int $id; 
 +     
 +    // Property is immutable, can only be written to during construction in private scope 
 +    protected string $email; 
 + 
 +    public function __construct(int $id, string $email) { 
 +        $this->id = $id; 
 +        $this->email = $email; 
 +    } 
 +} 
 +</code> 
  
  
 == Immutable semantics == == Immutable semantics ==
  
-An immutable property may only be written to in __construct(), and unset in __destruct(). +An immutable property may only be written to in construct and in other methods involved in object creation (set_state, unserialize, and wakeup), besides that it is allowed to be unset in destruct. 
-Unless otherwise specified in visibility, the write/unset access is available in protected scope.+
  
 +Unless otherwise specified in visibility, the write/unset access is available within protected scope.
  
  
-==== 2. Readonly attribute ====+== Reflection == 
 + 
 +When using reflection, methods such as ''ReflectionProperty::setAccessible()'' will work as before, it will implicit disable immutable flag. 
 + 
 +Furthermore the following method is proposed added to be able to detect immutable properties: 
 +- ''ReflectionProperty::isImmutable()'' 
 + 
 + 
 +"Reflection::getModifiers()" and "Reflection::getModifierNames()" will need adaption too to add int and keywords for "immutable". 
 + 
 +//TODO: Expand this with specific modifier int for "immutable"// 
 + 
 +==== 2. Attributes ==== 
 + 
 +With the recently accepted [[rfc:attributes_v2|Attribute v2 RFC]], another option here, or a supplemental one, would be to use attributes for introducing Readonly and Immutable semantics. Similar to how Rust does with its [[https://docs.rs/readonly/0.1.6/readonly/|readonly create]]. 
 + 
 +However the Attribute RFC does not allow for what is being drafted here, so this would need suggesting a way for userland classes to tell parser / compiler to enhance language features. 
 + 
 +**As such, maybe this should be completely omitted from the proposal?** Should we aim for concepts in 1.1, 1.2 and 3.0 in this RFC? 
 + 
 + 
 +=== 2.1 Readonly attribute ===
  
  
Line 177: Line 318:
  
 <code php> <code php>
-use PHP\Attribute\Property\Readonly;+use PHP\Attribute\PropertyVisibility\Readonly;
  
 class User { class User {
     <<Readonly>>     <<Readonly>>
-    public string $id;+    public int $id;
  
 +    // This property is not readonly
     public string $email;     public string $email;
-    +
     public function __construct(int $id, string $email) {     public function __construct(int $id, string $email) {
         $this->id = $id;         $this->id = $id;
Line 192: Line 334:
 </code> </code>
  
-Attribute can also be set on class level, implicit setting it on all fields unless they have their own Property attribute:+Attribute can also be set on class level, implicit setting it on all fields unless they have their own PropertyVisibility attribute:
  
 <code php> <code php>
-use PHP\Attribute\Property\Readonly;+use PHP\Attribute\PropertyVisibility\Readonly;
  
 <<Readonly>> <<Readonly>>
 class User { class User {
-    public string $id; +    // This property is readable in public scope and writeable in protected 
-    public string $email;+    public int $id;
          
 +    // This property is readable in protected scope and writeable in private
 +    protected string $email;
 +
     public function __construct(int $id, string $email) {     public function __construct(int $id, string $email) {
         $this->id = $id;         $this->id = $id;
Line 209: Line 354:
 </code>  </code> 
  
 +//For readonly semantics see proposal 1.2//
  
-//TODO: Define semantic in detail, see [[https://docs.rs/readonly/0.1.6/readonly/|Rust's]] // 
  
 +== Reflection ==
  
-==== 3. Immutable attribute ====+//TODO: show example on reading /setting attribute via reflection, and how this relates to "ReflectionProperty::setAccessible()".//
  
-This proposal adds support for runtime-enforced immutable write visibility for declared properties. The following example illustrates the basic syntax:+ 
 + 
 +=== 2.2. Immutable attribute === 
 + 
 +This proposal adds a compiler attribute which implies a runtime-enforced immutable write visibility checks for declared properties. The following example illustrates the basic syntax:
  
 <code php> <code php>
-use PHP\Attribute\Property\Immutable;+use PHP\Attribute\PropertyVisibility\Immutable;
  
 class User { class User {
     <<Immutable>>     <<Immutable>>
-    public string $id;+    public int $id;
  
     public string $email;     public string $email;
-    +
     public function __construct(int $id, string $email) {     public function __construct(int $id, string $email) {
         $this->id = $id;         $this->id = $id;
Line 235: Line 385:
  
  
-Attribute can also be set on class level, implicit setting it on all fields unless they have their own Property attribute:+Attribute can also be set on class level, implicit setting it on all fields unless they have their own PropertyVisibility attribute:
  
 <code php> <code php>
-use PHP\Attribute\Property\Immutable;+use PHP\Attribute\PropertyVisibility\Immutable;
  
 <<Immutable>> <<Immutable>>
 class User { class User {
-    public string $id;+    public int $id;
     public string $email;     public string $email;
-    +
     public function __construct(int $id, string $email) {     public function __construct(int $id, string $email) {
         $this->id = $id;         $this->id = $id;
Line 253: Line 403:
  
  
-//TODO: Define semantic in detail, see C#'s [[https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/language-specification/classes#readonly-fields|readonly fields]]//+//For immutable semantics see proposal 1.3// 
 + 
 +== Reflection == 
 + 
 +//TODO: show example on reading /setting attribute via reflection, and how this relates to ''ReflectionProperty::setAccessible()''.// 
  
  
Line 260: Line 415:
 Code that expects to be able to make properties writeable via reflection will have to adapt for new code taking advantage of this. Code that expects to be able to make properties writeable via reflection will have to adapt for new code taking advantage of this.
  
-While ReflectionProperty::setAccessible() will still work like before, checks using isProtected() or isPrivate() won't detect if class has other visibility for write (proposal #1), or take into account specific attributes affecting write (assuming proposal #1 is voted down and Readonly and Immutable becomes own attribute logic instead of merely syntax sugar for #1)+While ''ReflectionProperty::setAccessible()'' will still work like before, checks using ''isProtected()'' or ''isPrivate()'' won't detect if class has other visibility for write (proposal #1), or take into account specific attributes affecting write (assuming proposal #1 is voted down and Readonly and Immutable becomes own attribute logic instead of merely syntax sugar for #1.x)
  
  
Line 273: Line 428:
 ===== Performance ===== ===== Performance =====
  
-//Performance tests will need to be done once there is a implementation of this. Then overhead on properties, as well as measuring benefit over using magic methods.//+//Performance tests will need to be done once there is an implementation of this. Then overhead on properties, as well as measuring benefit over using magic methods.//
  
 ===== Vote ===== ===== Vote =====
  
 As this is a language change, a 2/3 majority is required. As this is a language change, a 2/3 majority is required.
-//RFC is in draft, and will undergo discussion phase before it is put for a vote.//+ 
 +===== References ===== 
 + 
 + 
 +  * [[https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/language-specification/classes#readonly-fields|C# readonly fields]], semantically similar to what is proposed as "immutable" here. 
 +  * [[https://docs.rs/readonly/0.1.6/readonly/|Rust readonly create]]
  
  
Line 291: Line 451:
 Significant changes to the RFC are noted here. Significant changes to the RFC are noted here.
  
-  * 2020-06-20 Initial RFC draft.+  * 2020-06-21 Initial early draft to get feedback on direction
  
  
rfc/readonly_and_immutable_properties.1592679478.txt.gz · Last modified: 2020/06/20 18:57 by andrerom

Page Tools