rfc:protectedlookup

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revision Previous revision
Next revision
Previous revision
rfc:protectedlookup [2008/06/03 13:52]
robinf
rfc:protectedlookup [2017/09/22 13:28] (current)
Line 4: Line 4:
   * Author: Robin Fernandes <​robinf@php.net>​   * Author: Robin Fernandes <​robinf@php.net>​
   * First Published at: http://​wiki.php.net/​rfc/​protectedlookup   * First Published at: http://​wiki.php.net/​rfc/​protectedlookup
-  * Status: ​in the works+  * Status: ​Draft (Inactive)
  
  
Line 177: Line 177:
 Remove new rule: remove calls to zend_get_function_root_class(). Remove new rule: remove calls to zend_get_function_root_class().
 === Patch === === Patch ===
-[[http://​thread.gmane.org/​gmane.comp.php.devel/​48176/​focus=48179|Patch from Felipe Pena]]+  * [[http://​thread.gmane.org/​gmane.comp.php.devel/​48176/​focus=48179|Patch from Felipe Pena]] 
 +  * [[http://​www.soal.org/​php/​protectedrfc/​protected_opt1_tests.zip|Tests]]
 === Pros === === Pros ===
   * Simple code change   * Simple code change
Line 211: Line 212:
 If option 1 is dismissed due to the violation of LSP, it follows that the current rules for property access, callbacks, ''​clone()''​ and ''​destruct()''​ are also violations of LSP and should be fixed. This option ensures that ''​zend_get_function_root_class()''​ is used consistently for all protected method checks, and implements equivalent functionality for protected property checks. If option 1 is dismissed due to the violation of LSP, it follows that the current rules for property access, callbacks, ''​clone()''​ and ''​destruct()''​ are also violations of LSP and should be fixed. This option ensures that ''​zend_get_function_root_class()''​ is used consistently for all protected method checks, and implements equivalent functionality for protected property checks.
 === Patch === === Patch ===
- To do.+  * [[http://​www.soal.org/​php/​protectedrfc/​protected_opt2.txt|Patch]] 
 +  * [[http://​www.soal.org/​php/​protectedrfc/​protected_opt2_tests.zip|Tests]]
 === Pros === === Pros ===
   * Respects the Liskov Substitution Principle.   * Respects the Liskov Substitution Principle.
Line 244: Line 246:
 </​code>​ </​code>​
 === Patch === === Patch ===
- ​To ​do.+  * Patch to do. 
 +  * [[http://​www.soal.org/​php/​protectedrfc/​protected_opt3_tests.zip|Tests]]
 === Pros === === Pros ===
   * Respects the Liskov Substitution Principle.   * Respects the Liskov Substitution Principle.
rfc/protectedlookup.1212501150.txt.gz · Last modified: 2017/09/22 13:28 (external edit)