rfc:phar_stop_autoloading_metadata

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revisionPrevious revision
Next revision		Previous revision
rfc:phar_stop_autoloading_metadata [2020/07/22 17:22] – tandrerfc:phar_stop_autoloading_metadata [2020/08/04 13:43] (current) – close the vote tandre
Line 3: Line 3:
   * Date: 2020-07-07   * Date: 2020-07-07
   * Author: Tyson Andre <tandre@php.net>   * Author: Tyson Andre <tandre@php.net>
-  * Status: Voting+  * Status: Implemented
   * First Published at: https://wiki.php.net/rfc/phar_stop_autoloading_metadata   * First Published at: https://wiki.php.net/rfc/phar_stop_autoloading_metadata
   * Implementation: https://github.com/php/php-src/pull/5855   * Implementation: https://github.com/php/php-src/pull/5855
Line 39: Line 39:
  
 Yes/No, requiring 2/3 majority to stop automatically unserializing metadata. Yes/No, requiring 2/3 majority to stop automatically unserializing metadata.
-Voting started on 2020-07-21 and ends 2020-08-04.+Voting started on 2020-07-21 and ended 2020-08-04.
  
-<doodle title="Stop automatically unserializing Phar metadata outside direct getMetadata() calls" auth="tandre" voteType="single" closed="false">+<doodle title="Stop automatically unserializing Phar metadata outside direct getMetadata() calls" auth="tandre" voteType="single" closed="true">
    * Yes    * Yes
    * No    * No
Line 62: Line 62:
 ===== Changelog ===== ===== Changelog =====
  
-0.4: Change from ''getMetadata($allowed_classes = ...)'' to ''getMetadata(array $unserialize_options = [])'' in this document. I forgot about max_depth being added in php 8.0 and the usefulness of being able to support future options added to unserialize() without changing the signature of getMetadata. Elaborate on implementation details ''$unserialize_options'' would lead to when setMetaData is called before ''%%$pharFileOrEntry->getMetadata(['allowed_classes' = $classes])%%''+0.4: Change from ''getMetadata($allowed_classes = ...)'' to ''getMetadata(array $unserialize_options = [])'' in this document. I forgot about max_depth being added in php 8.0 and the usefulness of being able to support future options added to unserialize() without changing the signature of getMetadata. Elaborate on implementation details ''$unserialize_options'' would lead to when setMetaData is called before ''%%$pharFileOrEntry->getMetadata(['allowed_classes' => $classes])%%''
  
 0.3: Clarify wording, add link to RFC announcement thread. Remove inapplicable ini defaults section. 0.3: Clarify wording, add link to RFC announcement thread. Remove inapplicable ini defaults section.
  
 0.2: Link to implementation. 0.2: Link to implementation.
rfc/phar_stop_autoloading_metadata.txt · Last modified: 2020/08/04 13:43 by tandre

Page Tools