rfc:pdo_driver_specific_subclasses

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revisionPrevious revision
Next revision		Previous revision
Last revisionBoth sides next revision
rfc:pdo_driver_specific_subclasses [2023/06/27 12:45] – Added note of leaving deprecation out and ini settings. danackrfc:pdo_driver_specific_subclasses [2024/01/11 22:24] – kocsismate
Line 3: Line 3:
   * Date: 2022-06-20    * Date: 2022-06-20 
   * Author: Danack   * Author: Danack
-  * Status: Under Discussion+  * Status: Implemented
   * First Published at: https://wiki.php.net/rfc/pdo_driver_specific_subclasses   * First Published at: https://wiki.php.net/rfc/pdo_driver_specific_subclasses
  
Line 136: Line 136:
      * @cname SQLITE_DETERMINISTIC      * @cname SQLITE_DETERMINISTIC
      */      */
-    public const SQLITE_DETERMINISTIC = UNKNOWN;+    public const DETERMINISTIC = UNKNOWN;
  
     /**     /**
Line 142: Line 142:
      * @cname SQLITE_ATTR_OPEN_FLAGS      * @cname SQLITE_ATTR_OPEN_FLAGS
      */      */
-    public const SQLITE_ATTR_OPEN_FLAGS = UNKNOWN;+    public const ATTR_OPEN_FLAGS = UNKNOWN;
  
     /**     /**
Line 148: Line 148:
      * @cname SQLITE_OPEN_READONLY      * @cname SQLITE_OPEN_READONLY
      */      */
-    public const SQLITE_OPEN_READONLY = UNKNOWN;+    public const OPEN_READONLY = UNKNOWN;
  
     /**     /**
Line 154: Line 154:
      * @cname SQLITE_OPEN_READWRITE      * @cname SQLITE_OPEN_READWRITE
      */      */
-    public const SQLITE_OPEN_READWRITE = UNKNOWN;+    public const OPEN_READWRITE = UNKNOWN;
  
     /**     /**
Line 160: Line 160:
      * @cname SQLITE_OPEN_CREATE      * @cname SQLITE_OPEN_CREATE
      */      */
-    public const SQLITE_OPEN_CREATE = UNKNOWN;+    public const OPEN_CREATE = UNKNOWN;
  
     /**     /**
Line 166: Line 166:
      * @cname SQLITE_ATTR_READONLY_STATEMENT      * @cname SQLITE_ATTR_READONLY_STATEMENT
      */      */
-    public const SQLITE_ATTR_READONLY_STATEMENT = UNKNOWN;+    public const ATTR_READONLY_STATEMENT = UNKNOWN;
  
     /**     /**
Line 172: Line 172:
      * @cname      * @cname
      */      */
-    public const SQLITE_ATTR_EXTENDED_RESULT_CODES = UNKNOWN;+    public const ATTR_EXTENDED_RESULT_CODES = UNKNOWN;
  
     // Registers an aggregating User Defined Function for use in SQL statements     // Registers an aggregating User Defined Function for use in SQL statements
Line 203: Line 203:
         int $rowid,         int $rowid,
         ?string $dbname = "main", //null,         ?string $dbname = "main", //null,
-        int $flags = PdoSqlite::SQLITE_OPEN_READONLY+        int $flags = PdoSqlite::OPEN_READONLY
     ): mixed /* resource|false */ {}     ): mixed /* resource|false */ {}
 } }
Line 285: Line 285:
  
 Everything not PDO Everything not PDO
 +
 +===== Frequently asked questions =====
 +
 +==== if someone does 'new PDO(...)' will they now get back 'PdoPgsql' ==== 
 +
 +No.
  
 ===== Future Scope ===== ===== Future Scope =====
Line 323: Line 329:
 Accept the RFC or not. Accept the RFC or not.
  
-===== Patches and Tests =====+<doodle title="PDO driver specific subclasses" auth="Danack" voteType="single" closed="false" closeon="2023-07-17T17:00:00Z"> 
 +   * Yes 
 +   * No 
 +</doodle>
  
-WIP code https://github.com/php/php-src/pull/8707+Voting closes at 2023-07-17T17:00:00Z
  
 +===== Patches and Tests =====
 +
 +https://github.com/php/php-src/pull/12804
 +https://github.com/php/php-src/pull/8707 (superseded version)
  
 ===== Implementation ===== ===== Implementation =====
-After the project is implemented, this section should contain  + 
-  - the version(s) it was merged into +Implemented for PHP 8.4 (https://github.com/php/php-src/commit/d6a0b3af68a55836ad7d24d4d832898c5b8c2d8e).
-  - a link to the git commit(s) +
-  - a link to the PHP manual entry for the feature +
-  - a link to the language specification section (if any)+
  
 ===== References ===== ===== References =====
  
-A proprosal to add [[rfc:implement_sqlite_openblob_in_pdo|sqlite openblob functionality]] previously failed to pass. The discussion gave the impression that the sub-classing [[ https://externals.io/message/100773#100813|approach would be more acceptable]].+A proposal to add [[rfc:implement_sqlite_openblob_in_pdo|sqlite openblob functionality]] previously failed to pass. The discussion gave the impression that the sub-classing [[ https://externals.io/message/100773#100813|approach would be more acceptable]].
  
 ===== Rejected Features ===== ===== Rejected Features =====
  
 Keep this updated with features that were discussed on the mail lists. Keep this updated with features that were discussed on the mail lists.
rfc/pdo_driver_specific_subclasses.txt · Last modified: 2024/02/12 14:24 by derick

Page Tools