rfc:pdo-mysql-get-warning-count

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Next revision		Previous revision
rfc:pdo-mysql-get-warning-count [2021/02/26 16:42] – created danielbeardsleyrfc:pdo-mysql-get-warning-count [2021/07/27 08:10] (current) – fix voting dates (2020 -> 2021) salathe
Line 3: Line 3:
   * Date: 2021-02-26   * Date: 2021-02-26
   * Author: Daniel Beardsley, dbeardsl@gmail.com   * Author: Daniel Beardsley, dbeardsl@gmail.com
-  * Status: Draft+  * Status: Declined (Abandoned)
  
 ===== Introduction ===== ===== Introduction =====
Line 9: Line 9:
  
 ===== Proposal ===== ===== Proposal =====
-Add a function that exposes the warning count of the most recent statement for MySQL: ''$pdo->mysqlGetWarningCount()''. It returns an ''int'' straight from the MySQL driver.+Add a function that exposes the warning count of the most recent statement for MySQL: ''$pdo->mysqlGetWarningCount()''. It returns an ''int'' straight from the MySQL driver. This fixes the open bug at: https://bugs.php.net/bug.php?id=51499.
  
 ===== Caveat ===== ===== Caveat =====
-I didn't look at every one, but most other SQL drivers don't seem to have a concept of "SHOW WARNINGS" and thus this feature (getting the warning count) only really applies to MySQL.+I didn't look at every one, but most other SQL drivers don't seem to have a concept of "SHOW WARNINGS" and thus this feature (getting the warning count) only really applies to MySQL. Regarding maintenance, the MySQL function that this code wraps hasn't change in decades and isn't likely to change in the future, so maintenance should be low to nil.
  
 ===== Backward Incompatible Changes ===== ===== Backward Incompatible Changes =====
Line 21: Line 21:
  
 ===== Proposed Voting Choices ===== ===== Proposed Voting Choices =====
-"Yes" means this pull should be merged (pending code review). "No" means we don't want PDO to expose MySQLs warning count.+"Yes" means this pull request should be merged (pending code review). "No" means we don't want PDO to expose MySQLs warning count.
  
 ===== Patches and Tests ===== ===== Patches and Tests =====
 There's an open pull with tests: https://github.com/php/php-src/pull/6677 There's an open pull with tests: https://github.com/php/php-src/pull/6677
 +
 +===== Vote ======
 +Voting opened on 2021-07-06 and closes on 2021-07-21
 +
 +<doodle title="Add PDO function: mysqlGetWarningCount" auth="danielbeardsley" voteType="single" closed="true">
 +   * Yes
 +   * No
 +</doodle>
 +
  
rfc/pdo-mysql-get-warning-count.1614357722.txt.gz · Last modified: 2021/02/26 16:42 by danielbeardsley

Page Tools