rfc:notice-for-non-valid-array-container
Differences
This shows you the differences between two versions of the page.
Both sides previous revisionPrevious revisionNext revision | Previous revisionNext revisionBoth sides next revision | ||
rfc:notice-for-non-valid-array-container [2016/08/16 15:57] – bp1222 | rfc:notice-for-non-valid-array-container [2016/08/24 15:48] – bp1222 | ||
---|---|---|---|
Line 35: | Line 35: | ||
This RFC aims to limit the quantity of warnings on a single line, however, large projects may have many locations that might need variable type checking around unknown container access. | This RFC aims to limit the quantity of warnings on a single line, however, large projects may have many locations that might need variable type checking around unknown container access. | ||
+ | |||
+ | ===== Performance Impact ===== | ||
+ | Test run was: | ||
+ | <file php> | ||
+ | <?php | ||
+ | $a = false; | ||
+ | for ($i = 0; $i < 1000000; $i++) { | ||
+ | $a[0]; | ||
+ | } | ||
+ | </ | ||
+ | |||
+ | Execution Time (DualCore 3ghz; 2g ram) | ||
+ | * Current Master : ~0.09s (~489m operations) | ||
+ | * Current Master w/RFC Displaying Warnings: ~33.25s (~7.799b operations) | ||
+ | * Current Master w/RFC Hiding Warnings: ~0.82s (~4.091b operations) | ||
+ | |||
+ | We can see there is a significant increase in operations on huge loads. | ||
===== Proposed PHP Version(s) ===== | ===== Proposed PHP Version(s) ===== | ||
Line 88: | Line 105: | ||
===== Proposed Voting Choices ===== | ===== Proposed Voting Choices ===== | ||
- | No syntax is changed, a vote of 50%+1 will be necessary | + | Requires 2/3 Vote |
<doodle title=" | <doodle title=" | ||
* Yes | * Yes | ||
Line 94: | Line 111: | ||
</ | </ | ||
Vote Start: 2016-08-16 15:36 | Vote Start: 2016-08-16 15:36 | ||
- | Vote End: | + | |
+ | Vote End: | ||
===== Patches and Tests ===== | ===== Patches and Tests ===== |
rfc/notice-for-non-valid-array-container.txt · Last modified: 2019/07/10 12:20 by nikic