rfc:new_rounding_modes_to_round_function

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revisionPrevious revision
Next revision		Previous revision
rfc:new_rounding_modes_to_round_function [2023/11/14 23:23] – jorg_sowarfc:new_rounding_modes_to_round_function [2023/12/21 15:21] (current) – Changed status to implemented jorg_sowa
Line 3: Line 3:
   * Target version: PHP 8.4   * Target version: PHP 8.4
   * Author: Jorg Sowa <jorg.sowa@gmail.com>   * Author: Jorg Sowa <jorg.sowa@gmail.com>
-  * Status: Under Discussion+  * Status: Implemented
   * Implementation: https://github.com/php/php-src/pull/12056   * Implementation: https://github.com/php/php-src/pull/12056
   * First Published at: http://wiki.php.net/rfc/new_rounding_modes_to_round_function   * First Published at: http://wiki.php.net/rfc/new_rounding_modes_to_round_function
Line 31: Line 31:
 Creating two aliases of constants from Intl extension to have consistent naming for rounding modes: Creating two aliases of constants from Intl extension to have consistent naming for rounding modes:
  
-  * ROUND_TOWARD_ZERO (equivalent of PHP_ROUND_TOWARD_ZERO) alias of [[https://www.php.net/manual/en/class.numberformatter.php#numberformatter.constants.round-up|ROUND_UP]] +  * ROUND_TOWARD_ZERO (equivalent of PHP_ROUND_TOWARD_ZERO) alias of [[https://www.php.net/manual/en/class.numberformatter.php#numberformatter.constants.round-down|ROUND_DOWN]] 
-  * ROUND_AWAY_FROM_ZERO (equivalent of PHP_ROUND_AWAY_FROM_ZERO) alias of [[https://www.php.net/manual/en/class.numberformatter.php#numberformatter.constants.round-down|ROUND_DOWN]]+  * ROUND_AWAY_FROM_ZERO (equivalent of PHP_ROUND_AWAY_FROM_ZERO) alias of [[https://www.php.net/manual/en/class.numberformatter.php#numberformatter.constants.round-up|ROUND_UP]]
  
 ===== Backward Incompatible Changes ===== ===== Backward Incompatible Changes =====
Line 57: Line 57:
  
 ==== Why not the enum implementation for the rounding modes? ==== ==== Why not the enum implementation for the rounding modes? ====
-As this is extension of the existing modes we should add complementary modes to the existing constants despite the decision of the enum implementation. This way enum is an addition to the new constants and is not included into this RFC.+As this is extension of the existing modes we should add complementary modes to the existing constants instead implementing new Enum. This way enum is an addition to the new constants and is not included into this RFC.
  
 ===== Proposed Voting Choices ===== ===== Proposed Voting Choices =====
Line 63: Line 63:
 As per the voting RFC a yes/no vote with a 2/3 majority is needed for this proposal to be accepted. As per the voting RFC a yes/no vote with a 2/3 majority is needed for this proposal to be accepted.
  
-Voting started on 2023-11-x and will end on 2023-11-x.+Voting started on 2023-11-15 and will end on 2023-11-30 00:00 GMT.
  
-Voting on implementing 4 new rounding modes to `round()` function.+<doodle title="Implement 4 new rounding modes to `round()` function" auth="jorg_sowa" voteType="single" closed="false" closeon="2023-11-30T00:00:00Z"> 
 +   * Yes 
 +   * No 
 +</doodle>
  
-Voting on creating aliases for Intl extension constants ROUND_UP and ROUND_DOWN: ROUND_AWAY_FROM_ZERO and ROUND_TOWARD_ZERO.+---- 
 + 
 +If the first voting is not accepted the result of the second voting will be ignored. 
 + 
 +<doodle title="Create aliases for Intl extension constants ROUND_UP and ROUND_DOWN: ROUND_AWAY_FROM_ZERO and ROUND_TOWARD_ZERO" auth="jorg_sowa" voteType="single" closed="false" closeon="2023-11-30T00:00:00Z"> 
 +   * Yes 
 +   * No 
 +</doodle>
  
 ===== Implementation ===== ===== Implementation =====
rfc/new_rounding_modes_to_round_function.1700004220.txt.gz · Last modified: 2023/11/14 23:23 by jorg_sowa

Page Tools