rfc:new_rounding_modes_to_round_function

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revisionPrevious revision
Next revision		Previous revision
rfc:new_rounding_modes_to_round_function [2023/10/04 22:20] – Deprecation of constants ROUND_UP and ROUND_DOWN jorg_sowarfc:new_rounding_modes_to_round_function [2023/12/21 15:21] (current) – Changed status to implemented jorg_sowa
Line 3: Line 3:
   * Target version: PHP 8.4   * Target version: PHP 8.4
   * Author: Jorg Sowa <jorg.sowa@gmail.com>   * Author: Jorg Sowa <jorg.sowa@gmail.com>
-  * Status: Under Discussion+  * Status: Implemented
   * Implementation: https://github.com/php/php-src/pull/12056   * Implementation: https://github.com/php/php-src/pull/12056
   * First Published at: http://wiki.php.net/rfc/new_rounding_modes_to_round_function   * First Published at: http://wiki.php.net/rfc/new_rounding_modes_to_round_function
Line 29: Line 29:
   * PHP_ROUND_TOWARD_ZERO - rounds num towards zero.   * PHP_ROUND_TOWARD_ZERO - rounds num towards zero.
  
-Deprecating two constants from Intl extension to have the consistency in the naming of rounding modes:+Creating two aliases of constants from Intl extension to have consistent naming for rounding modes:
  
-  * [[https://www.php.net/manual/en/class.numberformatter.php#numberformatter.constants.round-up|ROUND_UP]] +  * ROUND_TOWARD_ZERO (equivalent of PHP_ROUND_TOWARD_ZERO) alias of [[https://www.php.net/manual/en/class.numberformatter.php#numberformatter.constants.round-down|ROUND_DOWN]] 
-  * [[https://www.php.net/manual/en/class.numberformatter.php#numberformatter.constants.round-down|ROUND_DOWN]] +  * ROUND_AWAY_FROM_ZERO (equivalent of PHP_ROUND_AWAY_FROM_ZERO) alias of [[https://www.php.net/manual/en/class.numberformatter.php#numberformatter.constants.round-up|ROUND_UP]]
- +
-Instead creating two aliases of those constants: +
- +
-  * ROUND_TOWARD_ZERO (equivalent of PHP_ROUND_TOWARD_ZERO) +
-  * ROUND_AWAY_FROM_ZERO (equivalent of PHP_ROUND_AWAY_FROM_ZERO)+
  
 ===== Backward Incompatible Changes ===== ===== Backward Incompatible Changes =====
Line 60: Line 55:
  
 Those constants would be deprecated and replaced with their corresponding aliases: ROUND_TOWARD_ZERO and ROUND_AWAY_FROM_ZERO. Those constants would be deprecated and replaced with their corresponding aliases: ROUND_TOWARD_ZERO and ROUND_AWAY_FROM_ZERO.
 +
 +==== Why not the enum implementation for the rounding modes? ====
 +As this is extension of the existing modes we should add complementary modes to the existing constants instead implementing new Enum. This way enum is an addition to the new constants and is not included into this RFC.
  
 ===== Proposed Voting Choices ===== ===== Proposed Voting Choices =====
Line 65: Line 63:
 As per the voting RFC a yes/no vote with a 2/3 majority is needed for this proposal to be accepted. As per the voting RFC a yes/no vote with a 2/3 majority is needed for this proposal to be accepted.
  
-Voting started on 2023-09-x and will end on 2023-09-x.+Voting started on 2023-11-15 and will end on 2023-11-30 00:00 GMT. 
 + 
 +<doodle title="Implement 4 new rounding modes to `round()` function" auth="jorg_sowa" voteType="single" closed="false" closeon="2023-11-30T00:00:00Z"> 
 +   * Yes 
 +   * No 
 +</doodle> 
 + 
 +----
  
-Voting on implementing 4 new rounding modes to `round()` function.+If the first voting is not accepted the result of the second voting will be ignored.
  
-Voting on deprecating constants ROUND_UP and ROUND_DOWN and creating aliases for them: ROUND_AWAY_FROM_ZERO and ROUND_TOWARD_ZERO.+<doodle title="Create aliases for Intl extension constants ROUND_UP and ROUND_DOWN: ROUND_AWAY_FROM_ZERO and ROUND_TOWARD_ZERO" auth="jorg_sowa" voteType="single" closed="false" closeon="2023-11-30T00:00:00Z"> 
 +   * Yes 
 +   * No 
 +</doodle>
  
 ===== Implementation ===== ===== Implementation =====
rfc/new_rounding_modes_to_round_function.1696458033.txt.gz · Last modified: 2023/10/04 22:20 by jorg_sowa

Page Tools