| Both sides previous revisionPrevious revisionNext revision | Previous revision |
| rfc:make_ctor_ret_void [2020/07/08 20:14] – updated RFC moliata | rfc:make_ctor_ret_void [2020/07/22 15:29] (current) – updated RFC moliata |
|---|
| * Author: Benas Seliuginas, <benas.molis.iml@gmail.com> | * Author: Benas Seliuginas, <benas.molis.iml@gmail.com> |
| * Target version: PHP 8.0 | * Target version: PHP 8.0 |
| * Status: Voting | * Status: Declined |
| |
| Large credit for this RFC goes to Michael Voříšek who initially reported the bug and created a draft-- patch. | Large credit for this RFC goes to Michael Voříšek who initially reported the bug and created a draft-- patch. |
| rule <nowiki>*forbidding*</nowiki> them from having a return specifier//". | rule <nowiki>*forbidding*</nowiki> them from having a return specifier//". |
| |
| Another argument that is used against allowing explicit ''void'' return type is that it's going to create code-style wars and is duplicate information. But arguably, everyone also already knows what functions such as ''<nowiki>__</nowiki>toString()'' return. You know it's going to be a string. That's it's whole purpose. It would be surprising to see any code style forbidding that. Moreover, as of PHP 8.1, constructors and destructors will be the only methods that are not allowed to have a return type. This will be quite inconsistent given that ''<nowiki>__clone</nowiki>'' magic method will be able to have an explicit ''void'' return type even though both object construction and object cloning work in a similar fashion. | Another argument that is used against allowing explicit ''void'' return type is that it's going to create code-style wars and is duplicate information. But arguably, everyone also already knows what functions such as ''<nowiki>__</nowiki>toString()'' return. You know it's going to be a string. That's its whole purpose. It would be surprising to see any code style forbidding that. Moreover, as of PHP 8.0, constructors and destructors will be the only methods that are not allowed to have a return type. This will be quite inconsistent given that ''<nowiki>__clone</nowiki>'' magic method will be able to have an explicit ''void'' return type even though both object construction and object cloning work in a similar fashion. |
| |
| ===== Vote ===== | ===== Vote ===== |
| Voting opened July 8th, 2020 and will close July 22nd, 2020. | |
| |
| ==== Primary ==== | ==== Primary ==== |
| <doodle title="Make constructors/destructors return void?" auth="moliata" voteType="single" closed="false"> | <doodle title="Make constructors/destructors return void?" auth="moliata" voteType="single" closed="true"> |
| * Yes | * Yes |
| * No | * No |
| |
| ==== Secondary ==== | ==== Secondary ==== |
| <doodle title="Allow void return type on constructors/destructors?" auth="moliata" voteType="single" closed="false"> | <doodle title="Allow void return type on constructors/destructors?" auth="moliata" voteType="single" closed="true"> |
| * Yes | * Yes |
| * No | * No |