rfc:locked-classes
Differences
This shows you the differences between two versions of the page.
Both sides previous revisionPrevious revisionNext revision | Previous revision | ||
rfc:locked-classes [2019/03/10 18:04] – imsop | rfc:locked-classes [2019/06/04 18:56] (current) – Withdrawn imsop | ||
---|---|---|---|
Line 1: | Line 1: | ||
====== PHP RFC: Locked Classes ====== | ====== PHP RFC: Locked Classes ====== | ||
- | * Version: | + | * Version: 1.0 |
- | * Date: 2019-03-06 | + | * Date: 2019-03-10 |
* Author: Rowan Collins [IMSoP], rowan.collins@gmail.com | * Author: Rowan Collins [IMSoP], rowan.collins@gmail.com | ||
- | * Status: | + | * Status: |
* First Published at: http:// | * First Published at: http:// | ||
Line 10: | Line 10: | ||
Object properties in PHP are primarily defined in class definitions; | Object properties in PHP are primarily defined in class definitions; | ||
- | While setting properties which were not declared in a class definition, or unsetting properties which were declared, can be a useful tool, like many of PHP's dynamic features, it also makes certain mistakes easier. For instance, if a class defines a property '' | + | While setting properties which were not declared in a class definition, or unsetting properties which were declared, can be a useful tool, like many of PHP's dynamic features, it also makes certain mistakes easier. For instance, if a class defines a property '' |
Changing this behaviour for all objects would be a significant change to the language, with the potential to break a large amount of existing code. However, code written with no intention of using this dynamic behaviour would benefit from a way to switch it off. | Changing this behaviour for all objects would be a significant change to the language, with the potential to break a large amount of existing code. However, code written with no intention of using this dynamic behaviour would benefit from a way to switch it off. | ||
+ | |||
+ | While this can be achieved through strategic use of the '' | ||
===== Proposal ===== | ===== Proposal ===== | ||
Line 64: | Line 66: | ||
===== Naming ===== | ===== Naming ===== | ||
- | Newer versions of ECMAScript / JavaScript have [[https:// | + | Newer versions of ECMAScript / JavaScript have [[https:// |
Since the proposed modifier applies to a class, not an instance, it would be confusing to use the keyword " | Since the proposed modifier applies to a class, not an instance, it would be confusing to use the keyword " | ||
+ | |||
+ | The name " | ||
===== Backward Incompatible Changes ===== | ===== Backward Incompatible Changes ===== | ||
- | No internal classes, or classes in unmodified | + | The keyword " |
+ | |||
+ | No existing | ||
Since it is a new keyword, it will not be possible to " | Since it is a new keyword, it will not be possible to " | ||
Line 79: | Line 85: | ||
==== To Opcache ==== | ==== To Opcache ==== | ||
+ | |||
To be determined: are there any optimisations which interact with the behaviours being changed? | To be determined: are there any optimisations which interact with the behaviours being changed? | ||
Line 85: | Line 92: | ||
The following additions will be made to expose the new flag via reflection: | The following additions will be made to expose the new flag via reflection: | ||
- | * New constant ReflectionClass:: | + | |
- | * The return value of ReflectionClass:: | + | * The return value of ReflectionClass:: |
- | * Reflection:: | + | * Reflection:: |
- | * A new ReflectionClass:: | + | * A new ReflectionClass:: |
===== Unaffected PHP Functionality ===== | ===== Unaffected PHP Functionality ===== | ||
+ | Calling '' | ||
===== Future Scope ===== | ===== Future Scope ===== | ||
- | TODO | + | Classes defined by extensions could be marked " |
===== Proposed Voting Choices ===== | ===== Proposed Voting Choices ===== | ||
Line 100: | Line 107: | ||
===== Patches and Tests ===== | ===== Patches and Tests ===== | ||
- | https:// | + | A pull request containing an initial implementation with basic tests is available on github: |
+ | |||
+ | ===== Reasons for Withdrawal ===== | ||
+ | |||
+ | This RFC was discussed on the Internals list in March 2019. See archive here: https:// | ||
+ | |||
+ | While the reasoning behind the feature was welcomed, the general consensus was that it was not quite right in its current form. | ||
- | ===== Implementation ===== | + | Specific concerns raised included: |
- | TODO: After the project is implemented, | + | |
- | - the version(s) it was merged into | + | |
- | - a link to the git commit(s) | + | |
- | - a link to the PHP manual entry for the feature | + | |
- | - a link to the language specification section (if any) | + | |
- | ===== References ===== | + | * The handling of '' |
- | TODO | + | * The restriction on '' |
+ | * Contrary to both of the above suggestions, | ||
+ | * The extra keyword was considered " | ||
+ | * If the primary purpose is to prevent // | ||
- | ===== Rejected Features ===== | + | The feature proposed in this RFC was deliberately conservative to keep the implementation simple, and bring it to users as soon as possible. However, it may be sensible to revisit the idea in combination with other concepts, such as packages/ |
- | None yet | + |
rfc/locked-classes.1552241088.txt.gz · Last modified: 2019/03/10 18:04 by imsop