rfc:json_preserve_fractional_part

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revisionPrevious revision
Next revision		Previous revision
rfc:json_preserve_fractional_part [2014/12/25 18:37] – jrbassorfc:json_preserve_fractional_part [2017/09/22 13:28] (current) – external edit 127.0.0.1
Line 1: Line 1:
-====== PHP RFC: JSON Preserve Fractional Part ====== +====== PHP RFC: Preserve Fractional Part in JSON encode ====== 
-  * Version: 0.1+  * Version: 1.1
   * Date: 2014-12-25   * Date: 2014-12-25
   * Author: Juan Basso, jrbasso@gmail.com   * Author: Juan Basso, jrbasso@gmail.com
-  * Status: Draft+  * Status: Implemented (PHP 7.0)
   * First Published at: http://wiki.php.net/rfc/json_preserve_fractional_part   * First Published at: http://wiki.php.net/rfc/json_preserve_fractional_part
  
Line 18: Line 18:
 Testing the same behavior in other languages it shows that Go and JavaScript encode 10.0 to 10, but Python, C (lib jansson) and Ruby encode it to 10.0. Testing the same behavior in other languages it shows that Go and JavaScript encode 10.0 to 10, but Python, C (lib jansson) and Ruby encode it to 10.0.
  
-The goal of this RFC is propose a new json_encode option called JSON_PRESERVE_FRACTIONAL_PART to allow the same behavior of other languages and allowing the symmetry of the encode and decode. See below what changes:+The goal of this RFC is propose a new json_encode option called JSON_PRESERVE_ZERO_FRACTION to allow the same behavior of other languages and allowing the symmetry of the encode and decode. See below what changes:
  
 <PHP> <PHP>
 // Currently // Currently
 +echo json_encode(10.0); // Output 10
 +echo json_encode(10.1); // Output 10.1
 var_dump(json_decode(json_encode(10.0))); // Output int(10) var_dump(json_decode(json_encode(10.0))); // Output int(10)
 var_dump(10.0 === json_decode(json_encode(10.0))); // Output bool(false) var_dump(10.0 === json_decode(json_encode(10.0))); // Output bool(false)
  
 // Proposed // Proposed
-var_dump(json_decode(json_encode(10.0, JSON_PRESERVE_FRACTIONAL_PART))); // Output double(10) +echo json_encode(10.0); // Output 10 
-var_dump(10.0 === json_decode(json_encode(10.0, JSON_PRESERVE_FRACTIONAL_PART))); // Output bool(true)+echo json_encode(10.1); // Output 10.1 
 +echo json_encode(10.0, JSON_PRESERVE_ZERO_FRACTION); // Output 10.0 
 +echo json_encode(10.1, JSON_PRESERVE_ZERO_FRACTION); // Output 10.1 
 +var_dump(json_decode(json_encode(10.0, JSON_PRESERVE_ZERO_FRACTION))); // Output double(10) 
 +var_dump(10.0 === json_decode(json_encode(10.0, JSON_PRESERVE_ZERO_FRACTION))); // Output bool(true)
 </PHP> </PHP>
  
-A real case for this is handling amounts+A real case for this change is handling amounts, for example: 
 + 
 +<PHP> 
 +$order = ['subtotal' => 12.57, 'discount' => 12.57, 'total' => 0.0]; 
 +$encodeForSend = '{"subtotal":12.57,"discount":12.57,"total":0}'; 
 +// Send the JSON data 
 + 
 +// After receive the JSON 
 +$jsonReceived = '{"subtotal":12.57,"discount":12.57,"total":0}'; 
 +$order = json_decode($jsonReceived, true); 
 +if ($order['total'] === 0.0) { 
 +  // Do something 
 +} 
 +</PHP> 
 + 
 +On the code above, the if statement will fail because the number is not float as set when it was sent. The solution would be change it to be ''$order['total'] === 0.0 || $order['total'] === 0'' in case this value could assume null or boolean values for any reason. 
 + 
 +Having this option will give the option for developers to use it and increase the interoperability with other languages and also to increase the symmetry in PHP functions for cases like storing data in JSON.
  
 ===== Backward Incompatible Changes ===== ===== Backward Incompatible Changes =====
Line 49: Line 72:
  
 ==== New Constants ==== ==== New Constants ====
-- JSON_PRESERVE_FRACTIONAL_PART: Preserve the fraction part of float numbers with zero as decimal part.+- JSON_PRESERVE_ZERO_FRACTION: Preserve the fraction part of float numbers with zero as decimal part.
  
 ==== Performance ==== ==== Performance ====
Line 56: Line 79:
 The table below shows the performance of the code below (PS: not using the new flag): The table below shows the performance of the code below (PS: not using the new flag):
 <PHP> <PHP>
-$data = array_fill(0, 1000, 1.1);+$number = 1.0; // Or 1.1 
 +$data = array_fill(0, 1000, $number);
 $iterations = 10000; $iterations = 10000;
  
Line 84: Line 108:
 ===== Proposed Voting Choices ===== ===== Proposed Voting Choices =====
 This RFC requires a 50%+1 majority. This RFC requires a 50%+1 majority.
 +
 +<doodle title="Preserve Fractional Part in JSON encode" auth="jrbasso" voteType="single" closed="true">
 +   * Yes
 +   * No
 +</doodle>
 +
 +  * Voting opened: 2015-01-11 02:55 UTC
 +  * Voting closes: 2015-01-18 02:55 UTC
  
 ===== Patches and Tests ===== ===== Patches and Tests =====
 Currently implemented on https://github.com/php/php-src/pull/642 Currently implemented on https://github.com/php/php-src/pull/642
 +
 +===== Implementation =====
 +
 +Merged into jsond: https://github.com/bukka/php-src/pull/1
 +
 +jsond merged into 7.0: https://github.com/php/php-src/pull/993
  
 ===== Rejected Features ===== ===== Rejected Features =====
 None so far. None so far.
rfc/json_preserve_fractional_part.1419532627.txt.gz · Last modified: 2017/09/22 13:28 (external edit)

Page Tools