rfc:jit_config_defaults

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revisionPrevious revision
Next revision		Previous revision
rfc:jit_config_defaults [2023/11/15 16:48] – danogrfc:jit_config_defaults [2023/12/23 15:01] (current) – Close voting danog
Line 2: Line 2:
   * Date: 2023-11-15   * Date: 2023-11-15
   * Author: Daniil Gentili <daniil@daniil.it>   * Author: Daniil Gentili <daniil@daniil.it>
-  * Status: Under Discussion+  * Status: Accepted
  
  
Line 27: Line 27:
 The chosen JIT buffer size default is 64 mb, a reasonable default, given that any smaller multiple of The chosen JIT buffer size default is 64 mb, a reasonable default, given that any smaller multiple of
 2 causes the buffer to fill up when running moderately sized projects like Psalm or PHPStan. 2 causes the buffer to fill up when running moderately sized projects like Psalm or PHPStan.
 +
 +Another possible option for the default is 128 mb, which is incidentally also the maximum allowed JIT buffer size on the aarch64 architecture.
 +
  
 ===== Backward Incompatible Changes ===== ===== Backward Incompatible Changes =====
Line 47: Line 50:
 ===== Proposed Voting Choices ===== ===== Proposed Voting Choices =====
  
 +2/3 required to accept. Voting started on 2023-12-03 and will end on 2023-12-18 00:00 GMT. 
  
-<doodle title="Change how JIT is disabled by default?" auth="danog" voteType="single" closed="true">+<doodle title="Change how JIT is disabled by default?" auth="danog" voteType="single" closed="true" closeon="2023-12-18T00:00:00Z">
    * Yes    * Yes
    * No    * No
Line 55: Line 59:
 ===== Patches and Tests ===== ===== Patches and Tests =====
  
-Pull request: +Pull request: https://github.com/php/php-src/pull/12678
  
 ===== References ===== ===== References =====
rfc/jit_config_defaults.1700066894.txt.gz · Last modified: 2023/11/15 16:48 by danog

Page Tools