rfc:include_cleanup

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revisionPrevious revision
Next revision
Previous revision
rfc:include_cleanup [2023/01/30 09:52] – Adding link to comment removal PR maxkrfc:include_cleanup [2023/02/15 15:11] (current) – declined maxk
Line 3: Line 3:
   * Date: 2023-01-18   * Date: 2023-01-18
   * Author: Max Kellermann, max.kellermann@ionos.com   * Author: Max Kellermann, max.kellermann@ionos.com
-  * Status: Under Discussion+  * Status: Declined
   * First Published at: https://github.com/php/php-src/pull/10216   * First Published at: https://github.com/php/php-src/pull/10216
  
Line 105: Line 105:
   * Is it allowed to forward-declare structs/unions/typedefs? (Yes/No)   * Is it allowed to forward-declare structs/unions/typedefs? (Yes/No)
   * Is it allowed to split a large header, e.g. move zend_result to a separate header, to reduce dependencies on catch-all headers such as zend_types.h? (Yes/No)   * Is it allowed to split a large header, e.g. move zend_result to a separate header, to reduce dependencies on catch-all headers such as zend_types.h? (Yes/No)
 +
 +===== Vote =====
 +
 +Voting started on 2023-02-01 (two weeks after the RFC was posted to php-internals) and will end on 2023-02-15 at 15:00 UTC (another two weeks).
 +
 +Primary vote:
 +
 +<doodle title="Should #include directives be cleaned up?" auth="maxk" voteType="single" closed="true" closeon="2023-02-15T15:00:00Z">
 +   * Yes
 +   * No
 +</doodle>
 +
 +Secondary (clarifications on how to clean up):
 +
 +<doodle title="Is it allowed to document an #include line with a code comment?" auth="maxk" voteType="single" closed="true" closeon="2023-02-15T15:00:00Z">
 +   * Yes
 +   * No
 +</doodle>
 +
 +<doodle title="Is it allowed to forward-declare structs/unions/typedefs?" auth="maxk" voteType="single" closed="true" closeon="2023-02-15T15:00:00Z">
 +   * Yes
 +   * No
 +</doodle>
 +
 +<doodle title="Is it allowed to split a large header to reduce dependencies?" auth="maxk" voteType="single" closed="true" closeon="2023-02-15T15:00:00Z">
 +   * Yes
 +   * No
 +</doodle>
  
 ===== Patches and Tests ===== ===== Patches and Tests =====
rfc/include_cleanup.1675072357.txt.gz · Last modified: 2023/01/30 09:52 by maxk