rfc:include_cleanup

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revisionPrevious revision
Next revision		Previous revision
Last revisionBoth sides next revision
rfc:include_cleanup [2023/01/30 09:23] – additions to "Criticism" section, added PR links maxkrfc:include_cleanup [2023/02/01 09:21] – Status:Voting maxk
Line 3: Line 3:
   * Date: 2023-01-18   * Date: 2023-01-18
   * Author: Max Kellermann, max.kellermann@ionos.com   * Author: Max Kellermann, max.kellermann@ionos.com
-  * Status: Under Discussion+  * Status: Voting
   * First Published at: https://github.com/php/php-src/pull/10216   * First Published at: https://github.com/php/php-src/pull/10216
  
Line 105: Line 105:
   * Is it allowed to forward-declare structs/unions/typedefs? (Yes/No)   * Is it allowed to forward-declare structs/unions/typedefs? (Yes/No)
   * Is it allowed to split a large header, e.g. move zend_result to a separate header, to reduce dependencies on catch-all headers such as zend_types.h? (Yes/No)   * Is it allowed to split a large header, e.g. move zend_result to a separate header, to reduce dependencies on catch-all headers such as zend_types.h? (Yes/No)
 +
 +===== Vote =====
 +
 +Voting started on 2023-02-01 (two weeks after the RFC was posted to php-internals) and will end on 2023-02-15 at 15:00 UTC (another two weeks).
 +
 +Primary vote:
 +
 +<doodle title="Should #include directives be cleaned up?" auth="maxk" voteType="single" closed="false" closeon="2023-02-15T15:00:00Z">
 +   * Yes
 +   * No
 +</doodle>
 +
 +Secondary (clarifications on how to clean up):
 +
 +<doodle title="Is it allowed to document an #include line with a code comment?" auth="maxk" voteType="single" closed="false" closeon="2023-02-15T15:00:00Z">
 +   * Yes
 +   * No
 +</doodle>
 +
 +<doodle title="Is it allowed to forward-declare structs/unions/typedefs?" auth="maxk" voteType="single" closed="false" closeon="2023-02-15T15:00:00Z">
 +   * Yes
 +   * No
 +</doodle>
 +
 +<doodle title="Is it allowed to split a large header to reduce dependencies?" auth="maxk" voteType="single" closed="false" closeon="2023-02-15T15:00:00Z">
 +   * Yes
 +   * No
 +</doodle>
  
 ===== Patches and Tests ===== ===== Patches and Tests =====
Line 115: Line 143:
  
 https://github.com/php/php-src/pull/10404 is a PR that adds a few third-party extensions to the CI; more extensions could easily be added. This is slighly out of this RFC's scope, but may help those who worry about extension breakages. https://github.com/php/php-src/pull/10404 is a PR that adds a few third-party extensions to the CI; more extensions could easily be added. This is slighly out of this RFC's scope, but may help those who worry about extension breakages.
 +
 +If voters decide that #include directives should not have code comments, then existing comments should be removed to reduce "clutter"; see https://github.com/php/php-src/pull/10472
  
 ===== References ===== ===== References =====
rfc/include_cleanup.txt · Last modified: 2023/02/15 15:11 by maxk

Page Tools