rfc:implement-strrstr-for-consistency

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revisionPrevious revision
Next revision		Previous revision
Last revisionBoth sides next revision
rfc:implement-strrstr-for-consistency [2019/06/20 02:42] – girgiasrfc:implement-strrstr-for-consistency [2019/06/20 12:06] – girgias
Line 7: Line 7:
  
 ===== Introduction ===== ===== Introduction =====
-Implement strrstr (and possibly strristr) for consistency with other string functions+Implement <php>strrstr</php> (and possibly <php>strristr</php>) for consistency with the <php>strpos</php> string functions family. 
 + 
 + 
 +Currently there exist no "proper" counter part to the <php>strstr</php> (and <php>stristr</php>) standard string function. 
 +There exist <php>strrchr</php> however it does not have the same signature as <php>strstr</php> nor <php>strchr</php> as <php>strchr</php> is an alias of <php>strstr</php>, nor does it provide the same features.
  
 ===== Proposal ===== ===== Proposal =====
-Currently there exist no "proper" counter par to the strstr (and stristr) standard string function. +Implement <php>strrstr</php> and <php>strristr</php> (?) in PHP 7.4 with the same features as <php>strstr</php>, meaning that the ''$needle'' parameter can accept multiple characters and add a boolean parameter ''$before_needle'' which has a default value of <php>false</php>. 
-There exist strrchr however it does not have the same signature as strstr nor strchr as strchr is an alias of strstr, nor does it provide the same features.+
  
 ===== Pros ===== ===== Pros =====
Line 21: Line 25:
   * Follows an old naming scheme   * Follows an old naming scheme
   * Adds a function alias to the language   * Adds a function alias to the language
-  * Easely implemented in userland+  * Easily implemented in userland
  
 ===== Backward Incompatible Changes ===== ===== Backward Incompatible Changes =====
Line 33: Line 37:
  
 ===== Proposed Voting Choices ===== ===== Proposed Voting Choices =====
-2/3 Majority for adding strrstr (and possibly strristr after discussion).+2/3 Majority for adding <php>strrstr</php> (and possibly <php>strristr</php> after discussion).
  
 ===== Patches and Tests ===== ===== Patches and Tests =====
Line 46: Line 50:
  
 ===== References ===== ===== References =====
-Links to external references, discussions or RFCs+Announcement on internals: [[https://externals.io/message/105997]]
  
rfc/implement-strrstr-for-consistency.txt · Last modified: 2019/07/03 10:11 by girgias

Page Tools