rfc:friend-classes
Differences
This shows you the differences between two versions of the page.
Both sides previous revisionPrevious revisionNext revision | Previous revision | ||
rfc:friend-classes [2016/01/08 04:45] – mdwheele | rfc:friend-classes [2018/07/14 12:52] (current) – vote end mdwheele | ||
---|---|---|---|
Line 1: | Line 1: | ||
====== PHP RFC: Class Friendship ====== | ====== PHP RFC: Class Friendship ====== | ||
- | * Version: 0.2.2 | + | * Version: |
- | * Date: 2015-12-10 | + | * Date: 2017-09-21 |
* Author: Dustin Wheeler, mdwheele@ncsu.edu | * Author: Dustin Wheeler, mdwheele@ncsu.edu | ||
- | * Status: | + | * Status: |
* First Published at: http:// | * First Published at: http:// | ||
Line 300: | Line 300: | ||
===== Proposed PHP Version(s) ===== | ===== Proposed PHP Version(s) ===== | ||
- | This proposal targets | + | I had intended to target |
===== RFC Impact ===== | ===== RFC Impact ===== | ||
==== To Opcache ==== | ==== To Opcache ==== | ||
This is an open issue pending code review. I am unfamiliar-enough with Opcache implementation to be able to appropriately assess impact. | This is an open issue pending code review. I am unfamiliar-enough with Opcache implementation to be able to appropriately assess impact. | ||
- | |||
- | ==== To Reflection API ==== | ||
- | New methods are added to '' | ||
- | |||
- | - '' | ||
- | - '' | ||
- | |||
- | ===== Open Issues ===== | ||
- | ==== Policy ==== | ||
- | * Implementation requires code review to advise on improvements as well as inform that Opcache was appropriately considered | ||
- | * Verify current PHP functionality around class property visibility is undisturbed | ||
- | |||
- | ==== Reflection API ==== | ||
- | * Implement new methods on '' | ||
===== Future Scope ===== | ===== Future Scope ===== | ||
Line 329: | Line 315: | ||
===== Proposed Voting Choices ===== | ===== Proposed Voting Choices ===== | ||
- | As this is a language | + | As this RFC adds syntax to the language, a 2/3 majority is required. (see [[voting]]) |
+ | |||
+ | Voting starts on 2018-07-06 21:00 UTC and closes on 2018-07-13 21:00 UTC. | ||
+ | |||
+ | <doodle title=" | ||
+ | * Yes | ||
+ | * No | ||
+ | </ | ||
===== Patches and Tests ===== | ===== Patches and Tests ===== | ||
- | I have implemented the RFC as described with tests to verify all usage examples above. | + | I have implemented the RFC as described with tests to verify all usage examples above. |
+ | |||
+ | https:// | ||
As this is my first contribution to PHP, it is my opinion that my request should be placed under higher scrutiny and I am completely ready and willing to accept all feedback to improve implementation. | As this is my first contribution to PHP, it is my opinion that my request should be placed under higher scrutiny and I am completely ready and willing to accept all feedback to improve implementation. | ||
Line 350: | Line 345: | ||
* v0.2.1 - Fix copy+paste error from ReflectionClass documentation regarding trait methods. | * v0.2.1 - Fix copy+paste error from ReflectionClass documentation regarding trait methods. | ||
* v0.2.2 - Remove voting choice on implementation detail. Remove example of combined future scope syntax. Correct lacking clarity that friendship applies to all protected members, not just properties. | * v0.2.2 - Remove voting choice on implementation detail. Remove example of combined future scope syntax. Correct lacking clarity that friendship applies to all protected members, not just properties. | ||
+ | * v1.0.0 - Final draft of RFC before re-opening discussion |
rfc/friend-classes.txt · Last modified: 2018/07/14 12:52 by mdwheele