rfc:final_anonymous_classes

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revisionPrevious revision
Next revision		Previous revision
rfc:final_anonymous_classes [2023/12/01 18:22] – Remove alternative proposals danogrfc:final_anonymous_classes [2023/12/23 15:04] (current) – danog
Line 2: Line 2:
   * Date: 2023-11-15   * Date: 2023-11-15
   * Author: Daniil Gentili <daniil@daniil.it>   * Author: Daniil Gentili <daniil@daniil.it>
-  * Status: Under Discussion+  * Status: Declined
  
 ===== Introduction ===== ===== Introduction =====
  
-This RFC proposes to add support for final anonymous classes, //or// make all anonymous classes final by default, with or without the possibility to make them non-final. +This RFC proposes to add support for final anonymous classes. 
  
 ===== Proposal ===== ===== Proposal =====
  
-This RFC proposes to either add support for final anonymous classes, //or// make all anonymous classes final by default, with or without the possibility to make them non-final. +This RFC proposes to add support for final anonymous classes. 
  
 This should also allow some additional opcache optimizations, such as any JIT logic gated behind a check on ZEND_ACC_FINAL, i.e. https://github.com/php/php-src/blob/master/ext/opcache/jit/zend_jit_trace.c#L4507. This should also allow some additional opcache optimizations, such as any JIT logic gated behind a check on ZEND_ACC_FINAL, i.e. https://github.com/php/php-src/blob/master/ext/opcache/jit/zend_jit_trace.c#L4507.
 +
 +Example syntax:
 +
 +<code php>
 +$x = new final class {};
 +</code>
 +
 +Extending a final anonymous class throws an error:
 +
 +<code php>
 +$x = new final class {};
 +class_alias($x::class, 'alias');
 +class aliasExtends extends alias {}
 +</code>
 +
 +''
 +Fatal error: Class aliasExtends cannot extend final class class@anonymous in %s on line %d
 +''
 +
  
 ===== Backward Incompatible Changes ===== ===== Backward Incompatible Changes =====
Line 28: Line 47:
 ===== Proposed Voting Choices ===== ===== Proposed Voting Choices =====
  
-2/3 required to accept.+2/3 required to accept. Voting started on 2023-12-03 and will end on 2023-12-18 00:00 GMT. 
  
-<doodle title="Add support for final anonymous classes?" auth="danog" voteType="single" closed="true">+<doodle title="Add support for final anonymous classes?" auth="danog" voteType="single" closed="true" closeon="2023-12-18T00:00:00Z">
    * Yes    * Yes
    * No    * No
Line 42: Line 61:
  
   * Pull request discussion: https://github.com/php/php-src/pull/11126   * Pull request discussion: https://github.com/php/php-src/pull/11126
-  * Internals discussion: https://externals.io/message/121356+  * Internals discussion: https://externals.io/message/121356, https://externals.io/message/121685
  
  
 ===== Rejected Features ===== ===== Rejected Features =====
 +
 +After feedback received from Nikolas Grekas in the last [RFC] discussion thread (https://externals.io/message/121685), I moved here a large chunk of the rationale and removed basically all the alternative polls I had initially planned to propose:
 +
 +<blockquote>
 +Hi Daniil,
 +
 +    >> While I'm open to Proposal 1, which introduces final anonymous classes
 +    >> without breaking BC, Proposals 2 and 3 are a different story.
 +    >> In summary, I advocate for the RFC to focus on the non-BC-breaking option.
 +    >> Let's maintain our commitment to stability and gradual evolution in PHP.
 +    >> Cheers,
 +    >> Nicolas
 +
 +    > Agree with your points, just adding final anonymous classes seems the best solution to me, but given the interest in alternative solutions both in the pull request discussion, and in the previous mailing list thread, I think I'll leave the other options in the RFC, to see how the votes will go (I'm actually curious myself :).
 +    > Regards,
 +    > Daniil Gentili
 +
 +I think this is a dangerous game. Breaking BC shouldn't be proposed unless absolutely needed IMHO.
 +
 + Nicolas
 +</blockquote>
 +
 +To be entirely honest, I'm a bit on the fence: on one hand, looking at code like ''new class {}'', you would assume that since the class apparently has no name, it should not be impossible to extend it, but on the other hand, there are valid usecases for extending even anonymous classes (comments in the PR (https://github.com/php/php-src/pull/11126) referenced proxying, I can think of phpunit mocking to a much, much lesser extent given that you should realistically (hopefully) never have to mock an anonymous class that does not already implement an interface), and completely precluding the possibility of extending a class that
 +
 +  - Has a name (even if it's not immediately obvious)
 +  - Can be referenced to using its name (''class_exists'', ''new ReflectionClass'', ''new $clazz'', and yes, even ''class_alias'')
 +
 +seems a tad bit too restrictive...
 +
 +On the other hand, I also really don't like non-final classes, in all of my projects, I use CS rules that force all classes to either be abstract or final, because unfortunately, I've had to work with a lot of code that very frequently violates encapsulation by using inheritance.
 +
 +Still, there are some useful patterns, mainly regarding testing and mocking, for example I use https://github.com/dg/bypass-finals as a dev dependency to make all final classes non-final at runtime to allow mocking in phpunit, but it works by installing a custom default stream contexts that intercepts requires, tokenizes files and removes final keywords from classes; this approach would break for anonymous classes if they were rendered final by default without an option to make them non-final. 
 +
 +This is why I remain ambivalent about the options, as seen both in my emails and in the original text of the RFC:
  
 Personally, I would have instead preferred the much cleaner approach of making all anonymous classes final by default, (preferrably) without offering the option to make them non-final. Personally, I would have instead preferred the much cleaner approach of making all anonymous classes final by default, (preferrably) without offering the option to make them non-final.
rfc/final_anonymous_classes.1701454941.txt.gz · Last modified: 2023/12/01 18:22 by danog

Page Tools