rfc:enum_v2

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revisionPrevious revision
Next revision		Previous revision
rfc:enum_v2 [2020/05/16 12:28] – ++ maxsemrfc:enum_v2 [2021/02/18 13:14] (current) – Move status to obsolete ilutov
Line 3: Line 3:
   * Date: 2020-05-14   * Date: 2020-05-14
   * Author: Max Semenik, maxsem.wiki@gmail.com   * Author: Max Semenik, maxsem.wiki@gmail.com
-  * Status: Draft+  * Status: Obsolete
   * First Published at: http://wiki.php.net/rfc/enum_v2   * First Published at: http://wiki.php.net/rfc/enum_v2
 +
 +//Note: this is a counterproposal to [[rfc:enum|this RFC]]//
  
 ===== Introduction ===== ===== Introduction =====
-The elevator pitch for the RFC. The first paragraph of this section will be slightly larger to give it emphasis; please write a good introduction.+Traditionally, PHP has used independent constants to represent related magic numbers. I propose to add a concept well known from many other languages, enumeration type. 
 + 
 +Consider the following perfectly valid code: 
 +<code php> 
 +preg_split($foo, $bar, LC_ALL * PHP_MAJOR_VERSION); 
 +</code> 
 + 
 +What will this call produce? I have no idea, either:) 
 + 
 +It would be so much better to have a more foolproof and type-safe version, like: 
 +<code php> 
 +preg_split($foo, $bar, Split::NoEmpty); 
 +</code>
  
 ===== Proposal ===== ===== Proposal =====
  
-=== Basics ===+==== Basics ====
 A simple enum: A simple enum:
 <code php> <code php>
Line 62: Line 76:
     baz = 1.5       // CompileError     baz = 1.5       // CompileError
 } }
 +
 +$x = 'this is a string';
 +$y = (foo)$x; // TypeError
 </code> </code>
  
-=== Type coercion and casts ===+==== Type coercion and casts ====
 Enums are implicitly coercible to bool and string: Enums are implicitly coercible to bool and string:
 <code php> <code php>
Line 76: Line 93:
 </code> </code>
  
-=== Enum operations ===+Enum types can be explicitly cast to each other and ''int'': 
 +<code php> 
 +$foo = (FileMode)123; 
 +$bar = SomeEnum::Const; 
 +$foo = (FileMode)$bar; 
 +</code> 
 + 
 +Conversion from other types is not checked, thus enums can hold values not covered by their constants. ''Enum::isKnownValue()'' will return `false` while ''Enum::toHumanReadableString()'' will return a numeric string instead of constant name(s). 
 + 
 +==== Enum operations ====
 Enums are immutable and don't support arithmetic operations: Enums are immutable and don't support arithmetic operations:
 <code php> <code php>
-$foo = +$foo = FileMode::Read; 
 +$foo = FileMode::Read + 1; // CompileError 
 +$foo += 1;                 // TypeError 
 +$bar = $foo + 1;           // TypeError 
 +</code> 
 + 
 +However, binary enums support bitwise operations: 
 +<code php> 
 +$foo = FileMode::Read | FileMode::Execute; 
 +$foo |= FileMode::Write; 
 +$foo &= ~FileMode::Read;
 </code> </code>
  
-=== Enum usage ===+==== Enum usage ====
 Concrete enum types can be used as typehints: Concrete enum types can be used as typehints:
 <code php> <code php>
Line 113: Line 149:
 </code> </code>
  
-=== Enums are classes ===+==== Internal representation ====
 Internally, enums are classes and enum constants are public class constants. This makes them the fourth OOP-ey type in PHP, along with ''class'', ''interface'' and ''trait''. They can be autoloaded just like the former types. All enums inherit from this base class (here is PHP pseudocode): Internally, enums are classes and enum constants are public class constants. This makes them the fourth OOP-ey type in PHP, along with ''class'', ''interface'' and ''trait''. They can be autoloaded just like the former types. All enums inherit from this base class (here is PHP pseudocode):
 <code php> <code php>
Line 120: Line 156:
     private int $value;     private int $value;
     private function __construct(); // It shouldn't be possible to create enums like this: $foo = new Enum();     private function __construct(); // It shouldn't be possible to create enums like this: $foo = new Enum();
-    public function isBinary() : bool;+    public function isBinary(): bool;
     public function __toString(): string {     public function __toString(): string {
         return (string)(int)$this->value;         return (string)(int)$this->value;
     }     }
 +    
     // Whether the current value is represented by one of this enum's constants     // Whether the current value is represented by one of this enum's constants
     // or their combination for binary enums     // or their combination for binary enums
-    public function isKnownValue() : bool;+    public function isKnownValue(): bool; 
 +     
 +    // Returns a human readable representation of this enum's value 
 +    // e.g. (FileMode::Read | FileMode::Write)->toHumanReadableString() would return 'Read | Write' 
 +    // For unrecognized values, returns a decimal (simple enums) or hexadecimal (binary enums) string. 
 +    public function toHumanReadableString(): string; 
 +     
 +    public static function parse(string $enum) : ?WhateverConcreteEnumTypeIsExtendingThis;
 } }
 </code> </code>
  
 +===== Conventions used in this document =====
 +Currently, PascalCase is used in enums due to author's experience with C#. While I believe that this convention is nice and makes enums conveniently distinct from PHP conventions that use camelCase for properties and UNDERSCORED_UPPERCASE for constants, I'm not attached to it. The recommended convention for use in language documentation and, subsequently, the PHP core will be determined during community discussion or voted for during the voting phase.
 +
 +Same applies to the ''Enum'' class name.
  
 ===== Backwards Incompatible Changes ===== ===== Backwards Incompatible Changes =====
Line 135: Line 183:
  
 ===== Proposed PHP Version(s) ===== ===== Proposed PHP Version(s) =====
-Next PHP 8.x (8.1?)+PHP 8.1?
  
 ===== Open Issues ===== ===== Open Issues =====
 Make sure there are no open issues when the vote starts! Make sure there are no open issues when the vote starts!
 +
 +  * Naming conventions
 +  * Base class name(s)
 +  * Type coercion details?
  
 ===== Unaffected PHP Functionality ===== ===== Unaffected PHP Functionality =====
Line 146: Line 198:
  
 ===== Future Scope ===== ===== Future Scope =====
-This section details areas where the feature might be improved in future, but that are not currently proposed in this RFC.+After this RFC is implemented, enums may be used for new features or factored into existing ones.
  
 ===== Proposed Voting Choices ===== ===== Proposed Voting Choices =====
-* Accept this RFC (yes / no)? +  * Accept this RFC (yes / no)? 
-* What should be Enum fully qualified name (\Enum / \PHP\Enum)?+  * What should be enum base class fully qualified name (''\Enum'' / ''\PHP\Enum'' / something else )? 
 +  * What enum constant naming convention should be used (PascalCase / camelCase / UPPER_UNDERSCORED)?
  
 ===== Patches and Tests ===== ===== Patches and Tests =====
Line 170: Line 223:
 ===== References ===== ===== References =====
 Links to external references, discussions or RFCs Links to external references, discussions or RFCs
-* https://wiki.php.net/rfc/enum+* https://wiki.php.net/rfc/enum - old proposal that wanted to introduce 
  
 ===== Rejected Features ===== ===== Rejected Features =====
 Keep this updated with features that were discussed on the mail lists. Keep this updated with features that were discussed on the mail lists.
rfc/enum_v2.1589632131.txt.gz · Last modified: 2020/05/16 12:28 by maxsem

Page Tools