| Both sides previous revisionPrevious revisionNext revision | Previous revisionNext revisionBoth sides next revision |
| rfc:deprecations_php_7_3 [2018/06/24 16:40] – nikic | rfc:deprecations_php_7_3 [2018/07/08 21:07] – Remove FILTER_SANITIZE_MAGIC_QUOTES (now in 7.4) nikic |
|---|
| * Author: Nikita Popov <nikic@php.net> | * Author: Nikita Popov <nikic@php.net> |
| * Status: Under Discussion | * Status: Under Discussion |
| | * Implementation: https://github.com/php/php-src/pull/3366 (unless other patch linked below) |
| |
| ===== Introduction ===== | ===== Introduction ===== |
| * Undocumented mbstring function aliases | * Undocumented mbstring function aliases |
| * String search functions with integer needle | * String search functions with integer needle |
| * fgetss() function and string.strip_tags filter | * ''fgetss()'' function and ''string.strip_tags'' filter |
| * Defining a free-standing assert() function | * Defining a free-standing ''assert()'' function |
| | * ''FILTER_FLAG_SCHEME_REQUIRED'' and ''FILTER_FLAG_HOST_REQUIRED'' flags |
| | * ''pdo_odbc.db2_instance_name'' php.ini directive |
| |
| ===== Proposal ===== | ===== Proposal ===== |
| The ''fgetss()'' function and the ''string.strip_tags'' stream filters expose the functionality of ''strip_tags()'' in a streaming matter. The need to support these makes the implementation of ''strip_tags()'' more complicated, as a streaming state machine is necessary. On the other hand, these functions seem to be of very little utility. ''strip_tags()'' itself, due to its limitations and known bugs, already has very few legitimate applications. There is no need to provide native support for streaming application on top of that. | The ''fgetss()'' function and the ''string.strip_tags'' stream filters expose the functionality of ''strip_tags()'' in a streaming matter. The need to support these makes the implementation of ''strip_tags()'' more complicated, as a streaming state machine is necessary. On the other hand, these functions seem to be of very little utility. ''strip_tags()'' itself, due to its limitations and known bugs, already has very few legitimate applications. There is no need to provide native support for streaming application on top of that. |
| |
| Proposed action: Mark ''fgetss()'' and ''SplFileObject::fgetss()'' as deprecated, so that a deprecation notice is emitted on every call. Generate a deprecation notice if the ''string.strip_tags'' stream filter is created. In PHP 8 the functions and the stream filter are removed. | Proposed action: Mark ''fgetss()'', ''gzgetss()'' and ''SplFileObject::fgetss()'' as deprecated, so that a deprecation notice is emitted on every call. Generate a deprecation notice if the ''string.strip_tags'' stream filter is created. In PHP 8 the functions and the stream filter are removed. |
| |
| ==== Defining a free-standing assert() function ==== | ==== Defining a free-standing assert() function ==== |
| |
| Proposed action: Generate a compile-time deprecation warning if an ''assert()'' function is declared. In PHP 8 this becomes a compile-error. | Proposed action: Generate a compile-time deprecation warning if an ''assert()'' function is declared. In PHP 8 this becomes a compile-error. |
| | |
| | ==== FILTER_FLAG_SCHEME_REQUIRED and FILTER_FLAG_HOST_REQUIRED ==== |
| | |
| | As of PHP 5.2.1 ''FILTER_VALIDATE_URL'' implies ''FILTER_FLAG_SCHEME_REQUIRED'' and ''FILTER_FLAG_HOST_REQUIRED''. Not only are these constants useless, they also create the incorrect impression that the scheme/host requirement can be disabled. |
| | |
| | Proposed action: Generate a deprecation warning if the ''FILTER_FLAG_SCHEME_REQUIRED'' or ''FILTER_FLAG_HOST_REQUIRED'' flags are explicitly set in calls to filter APIs (PHP currently has no mechanism to deprecate the constants themselves). In PHP 8 the constants will be removed. |
| | |
| | Implementation: https://github.com/php/php-src/pull/3322 |
| | |
| | ==== pdo_odbc.db2_instance_name php.ini directive ==== |
| | |
| | As of PHP 5.1.1 ''pdo_odbc.db2_instance_name'' was marked as deprecated in the manual, promising removal in a future version of PHP. This ini directive modifies the DB2INSTANCE environment variable for non Windows operating systems, allowing pdo_odbc to make cataloged connections to a DB2 database. |
| | |
| | The side effect here is that this setting is process wide and also affects the ODBC extension, which can create some hard to debug situations. Besides this, the PECL package, ibm_db2 seems to implement the exact same behavior which could also conflict. |
| | |
| | Proposed action: Add a deprecation notice if the ini directive has a value at module initialization. |
| | |
| | Implementations: https://gist.github.com/KalleZ/424ea78492cd5f4c2198cba6b25403d9 |
| |
| ===== Backward Incompatible Changes ===== | ===== Backward Incompatible Changes ===== |