rfc:debugging_pdo_prepared_statement_emulation_v2

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Next revision
Previous revision
rfc:debugging_pdo_prepared_statement_emulation_v2 [2016/11/17 22:09]
adambaratz created
rfc:debugging_pdo_prepared_statement_emulation_v2 [2018/03/01 23:27] (current)
carusogabriel RFC was implemented in PHP 7.2
Line 1: Line 1:
 ====== PHP RFC: Debugging PDO Prepared Statement Emulation v2 ====== ====== PHP RFC: Debugging PDO Prepared Statement Emulation v2 ======
-  * Version: 0.1+  * Version: 0.3
   * Date: 2016-11-17   * Date: 2016-11-17
   * Author: Adam Baratz adambaratz@php.net   * Author: Adam Baratz adambaratz@php.net
-  * Status: In Discussion+  * Status: Implemented (in PHP 7.2)
   * First Published at: https://wiki.php.net/rfc/debugging_pdo_prepared_statement_emulation_v2   * First Published at: https://wiki.php.net/rfc/debugging_pdo_prepared_statement_emulation_v2
  
Line 33: Line 33:
     FROM fruit     FROM fruit
     WHERE calories < ? AND colour = ?     WHERE calories < ? AND colour = ?
-Parsed SQL: [88] SELECT name, colour, calories+Sent SQL: [88] SELECT name, colour, calories
     FROM fruit     FROM fruit
     WHERE calories < 150 AND colour = 'red'     WHERE calories < 150 AND colour = 'red'
Line 51: Line 51:
 </code> </code>
  
-The "Parsed SQL" section will only be shown if the prepared statement emulation is enabled. This would allow this information to be accessed without any API changes. If prepared statement emulation is removed, as some have suggested it should be, this feature would vanish seamlessly.+The "Sent SQL" section will only be shown after a query is executed, if prepared statement emulation is enabled. This would allow this information to be accessed without any API changes. If prepared statement emulation is removed, as some have suggested it should be, this feature would vanish seamlessly.
  
 ===== Backward Incompatible Changes ===== ===== Backward Incompatible Changes =====
Line 60: Line 60:
  
 ===== Proposed Voting Choices ===== ===== Proposed Voting Choices =====
-This project requires a 50%+1 majority.+This project requires a 50%+1 majority. Voting opened on December 7th. It will end on 16 December 2016 at 0:00 UTC. 
 + 
 +<doodle title="Debugging PDO Prepared Statement Emulation v2" auth="adambaratz" voteType="single" closed="true"> 
 +   * Yes 
 +   * No 
 +</doodle> 
 + 
 +===== Patches and Tests ===== 
 +A working implementation with tests: https://github.com/adambaratz/php-src/commit/a030d2f4e6a13f3e6c10484fb5dbc4e8be6576c6 
 + 
 +===== References ===== 
 +Discussion on the internals mailing list: http://marc.info/?l=php-internals&m=148034706404511&w=2 
 + 
 +===== Implementation ===== 
 +This feature was implemented in PHP 7.2 ([[https://github.com/php/php-src/commit/d58231dda300b015260ea8fb17c28f8eebf1ec51|d58231dda300b015260ea8fb17c28f8eebf1ec51]]).
rfc/debugging_pdo_prepared_statement_emulation_v2.1479420560.txt.gz · Last modified: 2017/09/22 13:28 (external edit)