rfc:curl_user_agent

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revisionPrevious revision
Next revision
Previous revision
Last revisionBoth sides next revision
rfc:curl_user_agent [2021/06/25 13:59] paresyrfc:curl_user_agent [2021/06/25 14:23] paresy
Line 1: Line 1:
-====== PHP RFC: Your Title Here ======+====== PHP RFC: Default User-Agent for cURL======
   * Version: 1.0   * Version: 1.0
   * Date: 2021-06-25   * Date: 2021-06-25
Line 40: Line 40:
  
 ===== Open Issues ===== ===== Open Issues =====
-No issues left.+Discussion if the ini visibility should be PHP_INI_ALL or PHP_INI_SYSTEM 
 +https://github.com/php/php-src/pull/6834/files#r628774432
  
 ===== Unaffected PHP Functionality ===== ===== Unaffected PHP Functionality =====
Line 49: Line 50:
  
 ===== Proposed Voting Choices ===== ===== Proposed Voting Choices =====
-At the moment the php.ini option is placed inside the curl section. +At the moment the php.ini option is proposed inside the curl section. If the discussion should not end unanimously we should consider adding a voting option if the curl section or the global section should be targeted for the user_agent entry.
  
  
 ===== Patches and Tests ===== ===== Patches and Tests =====
-Links to any external patches and tests go here. +Tests are included in the following PR.
- +
-If there is no patch, make it clear who will create a patch, or whether a volunteer to help with implementation is needed. +
- +
-Make it clear if the patch is intended to be the final patch, or is just a prototype. +
- +
-For changes affecting the core language, you should also provide a patch for the language specification.+
  
 ===== Implementation ===== ===== Implementation =====
rfc/curl_user_agent.txt · Last modified: 2021/07/08 09:55 by paresy