rfc:complete_callstatc_magic
Differences
This shows you the differences between two versions of the page.
Both sides previous revisionPrevious revisionNext revision | Previous revision | ||
rfc:complete_callstatc_magic [2024/03/29 02:02] – daddyofsky | rfc:complete_callstatc_magic [2024/03/29 04:32] (current) – daddyofsky | ||
---|---|---|---|
Line 9: | Line 9: | ||
===== Introduction ===== | ===== Introduction ===== | ||
- | The **_ _callStatic** magic method should be invoked | + | The **_ _callStatic** magic method should be invoked when non-static public methods are called |
Line 53: | Line 53: | ||
However, the IDE cannot find **active** method, and the **Go to Definition** feature cannot be used. | However, the IDE cannot find **active** method, and the **Go to Definition** feature cannot be used. | ||
- | Somewhere in the internal code, there is code that matches the **active** method to the **scopeActive** method, but it's hidden, not easy to find. | + | Somewhere in the internal code not in _ _callStatic, there is code that matches the **active** method to the **scopeActive** method, but it's hidden, not easy to find. |
Line 128: | Line 128: | ||
public static __callStatic($method, | public static __callStatic($method, | ||
{ | { | ||
- | return (new RealRouter())-> | + | return (new static())-> |
} | } | ||
- | public function prefix() {} | + | public function prefix(): static |
+ | | ||
+ | // some code | ||
+ | |||
+ | return $this; | ||
+ | | ||
public function group() {} | public function group() {} | ||
... | ... | ||
Line 140: | Line 145: | ||
Aside from the fact that the method is not static, this code is very clear too. | Aside from the fact that the method is not static, this code is very clear too. | ||
+ | |||
+ | |||
+ | |||
+ | ==== Case 3 ==== | ||
+ | |||
+ | Let's make a custom facade in Laravel. | ||
+ | |||
+ | <code php> | ||
+ | <?php | ||
+ | // 1. app/ | ||
+ | namespace App\Services; | ||
+ | |||
+ | class CustomService | ||
+ | { | ||
+ | public function someMethod() {} | ||
+ | } | ||
+ | </ | ||
+ | |||
+ | <code php> | ||
+ | <?php | ||
+ | // 2. app/ | ||
+ | namespace App\Facades; | ||
+ | |||
+ | use Illuminate\Support\Facades\Facade; | ||
+ | |||
+ | class CustomFacade extends Facade | ||
+ | { | ||
+ | protected static function getFacadeAccessor() | ||
+ | { | ||
+ | return ' | ||
+ | } | ||
+ | } | ||
+ | </ | ||
+ | |||
+ | <code php> | ||
+ | <?php | ||
+ | // 3. app/ | ||
+ | namespace App\Providers; | ||
+ | |||
+ | use Illuminate\Support\ServiceProvider; | ||
+ | use App\Services\CustomService; | ||
+ | |||
+ | class AppServiceProvider extends ServiceProvider | ||
+ | { | ||
+ | public function register() | ||
+ | { | ||
+ | $this-> | ||
+ | return new CustomService(); | ||
+ | }); | ||
+ | } | ||
+ | } | ||
+ | </ | ||
+ | |||
+ | <code php> | ||
+ | <?php | ||
+ | use App\Facades\CustomFacade; | ||
+ | |||
+ | CustomFacade:: | ||
+ | </ | ||
+ | |||
+ | |||
+ | Now what if this RFC is accepted? | ||
+ | |||
+ | |||
+ | <code php> | ||
+ | <?php | ||
+ | // 1. app/ | ||
+ | namespace App\Services; | ||
+ | |||
+ | class CustomService | ||
+ | { | ||
+ | public static __callStatic($method, | ||
+ | { | ||
+ | return (new static())-> | ||
+ | } | ||
+ | |||
+ | public function someMethod() {} | ||
+ | } | ||
+ | </ | ||
+ | |||
+ | <code php> | ||
+ | <?php | ||
+ | use App\Services\CustomService; | ||
+ | |||
+ | CustomService:: | ||
+ | </ | ||
+ | |||
+ | That's it. | ||
+ | |||
+ | ---------------------- | ||
Line 146: | Line 241: | ||
Of course, calling non-static methods in a static-like manner can be confusing, but in modern PHP, it has already become common practice. | Of course, calling non-static methods in a static-like manner can be confusing, but in modern PHP, it has already become common practice. | ||
- | This change | + | I believe this change |
===== Proposal ===== | ===== Proposal ===== | ||
The proposal is simple. | The proposal is simple. | ||
+ | |||
Instead of throwing an error when a non-static public method is called statically, the **_ _callStatic** method should be invoked. | Instead of throwing an error when a non-static public method is called statically, the **_ _callStatic** method should be invoked. | ||
Line 186: | Line 282: | ||
===== Open Issues ===== | ===== Open Issues ===== | ||
None | None | ||
- | |||
- | ===== Unaffected PHP Functionality ===== | ||
===== Patches and Tests ===== | ===== Patches and Tests ===== |
rfc/complete_callstatc_magic.1711677730.txt.gz · Last modified: 2024/03/29 02:02 by daddyofsky