rfc:cachediterable_straw_poll

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revision Previous revision
Next revision
Previous revision
rfc:cachediterable_straw_poll [2021/06/05 00:24]
tandre
rfc:cachediterable_straw_poll [2021/06/13 14:33] (current)
tandre close poll
Line 1: Line 1:
 ====== PHP RFC: Straw poll: Namespace to use for CachedIterable and iterable functionality ====== ====== PHP RFC: Straw poll: Namespace to use for CachedIterable and iterable functionality ======
-  * Version: 0.1+  * Version: 0.2.1
   * Date: 2021-06-01   * Date: 2021-06-01
   * Author: Tyson Andre, <tandre@php.net>   * Author: Tyson Andre, <tandre@php.net>
-  * Status: Under Discussion+  * Status: Closed
   * First Published at: https://wiki.php.net/rfc/cachediterable_straw_poll   * First Published at: https://wiki.php.net/rfc/cachediterable_straw_poll
  
Line 17: Line 17:
 In particular, https://wiki.php.net/rfc/namespaces_in_bundled_extensions#core_standard_spl and https://wiki.php.net/rfc/namespaces_in_bundled_extensions#existing_non-namespaces_symbols_and_consistency can be interpreted in different ways - the RFC recommends the usage of namespaces for functionality in core, but permits functionality to use the global namespace if it would be consistent with similar non-namespaced functionality already in core/standard/spl. In particular, https://wiki.php.net/rfc/namespaces_in_bundled_extensions#core_standard_spl and https://wiki.php.net/rfc/namespaces_in_bundled_extensions#existing_non-namespaces_symbols_and_consistency can be interpreted in different ways - the RFC recommends the usage of namespaces for functionality in core, but permits functionality to use the global namespace if it would be consistent with similar non-namespaced functionality already in core/standard/spl.
  
-In addition to that, because this says "may" and "should" instead of "must", there +In addition to that, because that RFC says "may" and "should" instead of "must", it can be interpreted differently by different people. (I am assuming those words meant something similar to https://datatracker.ietf.org/doc/html/rfc2119 but that was not specified in the namespaces in bundled extensions RFC)
  
 ===== Proposal ===== ===== Proposal =====
  
-Create a straw poll for the functionality from [[rfc:cachediterable|CachedIterable]] and successors to the [[rfc:any_all_on_iterable|any() and all() on iterables]] RFC: [[https://github.com/php/php-src/pull/6053|any()/all()/none()/find()/reduce()]]+In this straw poll, gather feedback for the functionality from [[rfc:cachediterable|CachedIterable]] and successors to the [[rfc:any_all_on_iterable|any() and all() on iterables]] RFC: [[https://github.com/php/php-src/pull/6053|any()/all()/none()/find()/reduce()]]
  
 ===== Proposed Voting Choices ===== ===== Proposed Voting Choices =====
 +
 +Voting on this straw poll starts on June 5, 2021 and ends on June 12, 2021.
  
 **Note that due to a limitation of the wiki software, forms must be voted on separately.** **Note that due to a limitation of the wiki software, forms must be voted on separately.**
 If you are opposed to this functionality being added to PHP in any form, please note this in addition to your preferred namespacing choice, given that https://wiki.php.net/rfc/namespaces_in_bundled_extensions has passed. If you are opposed to this functionality being added to PHP in any form, please note this in addition to your preferred namespacing choice, given that https://wiki.php.net/rfc/namespaces_in_bundled_extensions has passed.
  
-https://wiki.php.net/rfc/namespaces_in_bundled_extensions strongly discourages some of the previously considered options+==== Namespace choices ==== 
 + 
 +https://wiki.php.net/rfc/namespaces_in_bundled_extensions strongly discourages some of the previously considered namespace options with too few or too many namespace parts.
  
 <blockquote> <blockquote>
Line 47: Line 51:
  
 Preferred namespacing choice for [[rfc:cachediterable|CachedIterable]] Preferred namespacing choice for [[rfc:cachediterable|CachedIterable]]
 +
 +(No namespace alternatives were suggested between announcing the straw poll and opening the straw poll in https://externals.io/message/114687#114687)
  
 <doodle title="Preferred namespacing choice for CachedIterable" auth="tandre" votetype="multi" closed="true"> <doodle title="Preferred namespacing choice for CachedIterable" auth="tandre" votetype="multi" closed="true">
Line 52: Line 58:
    * CachedIterable    * CachedIterable
    * Collections\CachedIterable    * Collections\CachedIterable
-   Other namespacing choice+   Opposed to previous namespace choices
    * Opposed to adding this functionality to php    * Opposed to adding this functionality to php
 </doodle> </doodle>
Line 64: Line 70:
    * Iterable\any()    * Iterable\any()
    * iterable_any()    * iterable_any()
-   Other namespacing choice+   Opposed to previous namespace choices
    * Opposed to adding this functionality to php    * Opposed to adding this functionality to php
 </doodle> </doodle>
Line 70: Line 76:
 \\ \\
  
-Functionality of interest in the successor to the [[rfc:any_all_on_iterable|any() and all() on iterables]] RFC: [[https://github.com/php/php-src/pull/6053|any()/all()/none()/find()/reduce()]]+Functionality of interest in the successor to the [[rfc:any_all_on_iterable|any() and all() on iterables]] RFC:  
 + 
 +[[https://github.com/php/php-src/pull/6053|Implementation of any()/all()/none()/find()/reduce()]]
  
 (functionality such as ''reversed()'', ''flip(iterable): CachedIterable'', etc. (which would require ''CachedIterable'') is left out of this question) (functionality such as ''reversed()'', ''flip(iterable): CachedIterable'', etc. (which would require ''CachedIterable'') is left out of this question)
  
-(in this proposal, find() and reduce() act only on values of iterables. Passing too many arguments is currently an error for internal functions and it is possible that it would be deprecated for user-defined functions in the future.)+(in this proposal, find() and reduce() act only on values of iterables, similar to how [[http://php.net/array_reduce|array_reduce]] works. Passing too many arguments is currently an error for internal functions and it is possible that it would be deprecated for user-defined functions in the future.
 + 
 +("Still too small in scope" means you would probably vote against the implementation as-is for that reason)
  
-<doodle title="Global functions I would want to add to PHP to act on iterables as described" auth="tandre" votetype="multi" closed="true">+<doodle title="Global functions I would want to add to PHP to act on iterables as described in implementation link" auth="tandre" votetype="multi"  closed="true">
    * any(...)/all(iterable $input, $callback = null): bool    * any(...)/all(iterable $input, $callback = null): bool
    * none(...): bool    * none(...): bool
Line 82: Line 92:
    * reduce(iterable $input, $callback, $initial = null): mixed    * reduce(iterable $input, $callback, $initial = null): mixed
    * Still too small in scope    * Still too small in scope
 +   * Opposed to adding this functionality to php
 +</doodle>
 +**EDIT: The redundant option "Opposed to adding this functionality to php" was added to the vote on global functions after the start of the vote** to make it easier to vote on at least one option. See "Preferred namespacing choice" for other voters opposed to the functionality.
 + 
 +
 +==== Preferred namespace case to use for iterable/Iterable ====
 +
 +I didn't notice this earlier, but the [[rfc:https://namespaces_in_bundled_extensions|Namespaces in Bundled Extensions RFC]] recommended (but didn't mandate) that "Namespace names should follow CamelCase." - so I'm not sure if ''iterable\'' or ''Iterable\'' makes the most sense to others.
 +
 +This poll asks whether ''iterable\'' or ''Iterable\'' makes more sense - It could be argued by some that namespaces such as ''iterable\'' should be an exception due to it also being used as a soft reserved keyword that is typically lowercase.
 +
 +https://externals.io/message/114687#114689
 +
 +<blockquote>
 +To me, a lower-case namespace like "iterable" just looks wrong, because
 +I'm so used to namespaces, like classes, being UpperCamels.
 +
 +The connection to a keyword doesn't seem convincing to me - if anything,
 +it highlights the possible confusion from choosing a namespace name that
 +has a different meaning elsewhere, although I admit no brilliant
 +alternatives spring to mind.
 +
 +Regards,
 +
 +--
 +Rowan Tommins
 +[IMSoP]
 +</blockquote>
 +
 +(Aside: shorter namespace names such as iter were unpopular in a [[rfc:any_all_on_iterable_straw_poll_namespace|previous straw poll]], and iter would conflict with https://github.com/nikic/iter)
 +
 +<doodle title="Preferred namespacing for iterable\" auth="tandre" votetype="single" closed="true">
 +   * iterable\ (lowercase)
 +   * Iterable\ (CamelCase)
 </doodle> </doodle>
  
 ===== References ===== ===== References =====
-https://externals.io/message/114687 "Namespaces in bundled extensions" and iterable additions to the standard library+ 
 +  * https://externals.io/message/114687 "Namespaces in bundled extensions" and iterable additions to the standard library 
 +  * https://wiki.php.net/rfc/namespaces_in_bundled_extensions 
 +  * https://wiki.php.net/rfc/any_all_on_iterable_straw_poll_namespace 
 + 
 +===== Changelog ===== 
 + 
 +0.2.1: Add "Opposed to adding this functionality to php" to the vote on which global functions to make voting on at least one option easier and note that it was also asked in the previous poll
rfc/cachediterable_straw_poll.1622852648.txt.gz · Last modified: 2021/06/05 00:24 by tandre