rfc:attribute_amendments

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revisionPrevious revision
Next revision
Previous revision
Last revisionBoth sides next revision
rfc:attribute_amendments [2020/06/08 08:10] – Start vote beberleirfc:attribute_amendments [2020/06/29 08:46] nikic
Line 4: Line 4:
   * Date: 2020-05-11   * Date: 2020-05-11
   * Author: Benjamin Eberlei (beberlei@php.net), Martin Schröder   * Author: Benjamin Eberlei (beberlei@php.net), Martin Schröder
-  * Status: Under Discussion+  * Status: Implemented
   * Target: 8.0   * Target: 8.0
   * First Published at: http://wiki.php.net/rfc/attribute_amendments   * First Published at: http://wiki.php.net/rfc/attribute_amendments
 +  * Patch: https://github.com/koolkode/php-src/pull/4
  
 ===== Introduction ===== ===== Introduction =====
Line 207: Line 208:
 ==== Rename PhpAttribute class to Attribute ==== ==== Rename PhpAttribute class to Attribute ====
  
-<doodle title="Should PhpAttribute be renamed to Attribute?" auth="beberlei" voteType="single" closed="false">+<doodle title="Should PhpAttribute be renamed to Attribute?" auth="beberlei" voteType="single" closed="true">
    * Yes    * Yes
    * No    * No
Line 214: Line 215:
 ==== Group statement for Attributes ==== ==== Group statement for Attributes ====
  
-<doodle title="Should a secondary grouped syntax for attributes be introduced?" auth="beberlei" voteType="single" closed="false">+<doodle title="Should a secondary grouped syntax for attributes be introduced?" auth="beberlei" voteType="single" closed="true">
    * Yes    * Yes
    * No    * No
Line 221: Line 222:
 ==== Validate Attribute Target Declarations ==== ==== Validate Attribute Target Declarations ====
  
-<doodle title="Should attributes allow definition of target declarations?" auth="beberlei" voteType="single" closed="false">+<doodle title="Should attributes allow definition of target declarations?" auth="beberlei" voteType="single" closed="true">
    * Yes    * Yes
    * No    * No
Line 228: Line 229:
 ==== Validate Attribute Repeatability ==== ==== Validate Attribute Repeatability ====
  
-<doodle title="Should attributes allow definition of repeatability?" auth="beberlei" voteType="single" closed="false">+<doodle title="Should attributes allow definition of repeatability?" auth="beberlei" voteType="single" closed="true">
    * Yes    * Yes
    * No    * No
Line 235: Line 236:
 ===== Patches and Tests ===== ===== Patches and Tests =====
  
-  - [[https://github.com/koolkode/php-src/pull/2|PR for Target and Repeatability Validations]] +  - https://github.com/koolkode/php-src/pull/4
-  - [[https://github.com/koolkode/php-src/pull/1|PR for Grouped Attributes Syntax]]+
  
 ===== References ===== ===== References =====
rfc/attribute_amendments.txt · Last modified: 2020/06/29 09:07 by beberlei