rfc:attribute_amendments

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revisionPrevious revision
Next revision		Previous revision
Last revisionBoth sides next revision
rfc:attribute_amendments [2020/06/04 16:42] – IS_REPEATABLE flag beberleirfc:attribute_amendments [2020/06/29 08:46] – nikic
Line 4: Line 4:
   * Date: 2020-05-11   * Date: 2020-05-11
   * Author: Benjamin Eberlei (beberlei@php.net), Martin Schröder   * Author: Benjamin Eberlei (beberlei@php.net), Martin Schröder
-  * Status: Under Discussion+  * Status: Implemented 
 +  * Target: 8.0
   * First Published at: http://wiki.php.net/rfc/attribute_amendments   * First Published at: http://wiki.php.net/rfc/attribute_amendments
 +  * Patch: https://github.com/koolkode/php-src/pull/4
  
 ===== Introduction ===== ===== Introduction =====
Line 198: Line 200:
 ===== Open Issues ===== ===== Open Issues =====
  
-  - For repeated attribute declaration: Use a dedicated attribute class or flags on //PhpAttribute//?+none 
 + 
 +===== Vote ===== 
 + 
 +Voting will end on June 22nd, 2020 - 8:00 UTC. 
 + 
 +==== Rename PhpAttribute class to Attribute ==== 
 + 
 +<doodle title="Should PhpAttribute be renamed to Attribute?" auth="beberlei" voteType="single" closed="true"> 
 +   * Yes 
 +   * No 
 +</doodle> 
 + 
 +==== Group statement for Attributes ==== 
 + 
 +<doodle title="Should a secondary grouped syntax for attributes be introduced?" auth="beberlei" voteType="single" closed="true"> 
 +   * Yes 
 +   * No 
 +</doodle> 
 + 
 +==== Validate Attribute Target Declarations ====
  
 +<doodle title="Should attributes allow definition of target declarations?" auth="beberlei" voteType="single" closed="true">
 +   * Yes
 +   * No
 +</doodle>
  
-===== Proposed Voting Choices =====+==== Validate Attribute Repeatability ====
  
-  - Should //PhpAttribute// be renamed to //Attribute//? +<doodle title="Should attributes allow definition of repeatability?" auth="beberlei" voteType="single" closed="true"> 
-  - Should a secondary grouped syntax for attributes be introduced? +   * Yes 
-  - Should attributes allow definition of target declarations? +   * No 
-  - Should attributes allow definition of repeatability?+</doodle>
  
 ===== Patches and Tests ===== ===== Patches and Tests =====
  
-  - [[https://github.com/koolkode/php-src/pull/2|PR for Target and Repeatability Validations]] +  - https://github.com/koolkode/php-src/pull/4
-  - [[https://github.com/koolkode/php-src/pull/1|PR for Grouped Attributes Syntax]]+
  
 ===== References ===== ===== References =====
rfc/attribute_amendments.txt · Last modified: 2020/06/29 09:07 by beberlei

Page Tools