rfc:sealed_classes

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revisionPrevious revision
Next revision
Previous revision
rfc:sealed_classes [2022/03/03 00:19] – added FAQ's section azjezzrfc:sealed_classes [2022/04/01 08:21] (current) – closed vote azjezz
Line 1: Line 1:
 ====== PHP RFC: Sealed Classes ====== ====== PHP RFC: Sealed Classes ======
   * Date: 2021-04-24   * Date: 2021-04-24
-  * Author: Saif Eddin Gmati <azjezz@protonmail.com>, Joe Watkins +  * Author: Saif Eddin Gmati <azjezz@protonmail.com>, Joe Watkins <krakjoe@php.net> 
-  * Status: Under Discussion+  * Status: Decline
   * Target Version: PHP 8.2   * Target Version: PHP 8.2
   * First Published at: https://wiki.php.net/rfc/sealed_classes   * First Published at: https://wiki.php.net/rfc/sealed_classes
Line 296: Line 296:
 == Would PHP check if permitted classes exists when loading a sealed class? == == Would PHP check if permitted classes exists when loading a sealed class? ==
  
-No, when leading a sealed class, PHP would treat just like any other class, and store the permitted types list to check against+No, when loading a sealed class, PHP would treat just like any other class, and store the permitted types list to check against
 later when another type tries to inherit from it. later when another type tries to inherit from it.
  
Line 349: Line 349:
  
  
-===== Proposed Voting Choices =====+===== Vote =====
  
 As this is a language change, a 2/3 majority is required. As this is a language change, a 2/3 majority is required.
  
-===== Patches and Tests ===== +Voting started on 2022-03-17 and will end on 2022-03-31.
-Links to any external patches and tests go here.+
  
-If there is no patch, make it clear who will create a patch, or whether a volunteer to help with implementation is needed.+<doodle title="Accept sealed classes RFC?" auth="azjezz" voteType="single" closed="true"> 
 +   * Yes 
 +   * No 
 +</doodle>
  
-Make it clear if the patch is intended to be the final patch, or is just a prototype.+A Second vote for the preferred syntax choice.
  
-For changes affecting the core language, you should also provide a patch for the language specification.+<doodle title="Which syntax option do you prefer?" auth="azjezz" voteType="single" closed="true"> 
 +   * `sealed` + `permits` 
 +   * `permits` only 
 +   * `for
 +</doodle>
  
 +===== Patches and Tests =====
 +
 +Prototype patch using `for` syntax: https://github.com/php/php-src/compare/master...azjezz:sealed-classes
  
 ===== References ===== ===== References =====
Line 371: Line 380:
 ===== Changelog ===== ===== Changelog =====
  
-1.1: added comparison to composite types. + 
-1.2: added FAQ's section.+  * 1.1: added comparison to composite types. 
 +  1.2: added FAQ's section.
  
rfc/sealed_classes.1646266759.txt.gz · Last modified: 2022/03/03 00:19 by azjezz