rfc:pdo_escape_placeholders

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revisionPrevious revision
Next revision
Previous revision
rfc:pdo_escape_placeholders [2019/05/31 11:10] – v0.2, draft mbeccatirfc:pdo_escape_placeholders [2020/08/01 23:55] (current) – RFC was implemented carusogabriel
Line 1: Line 1:
 ====== PHP RFC: Escape PDO "?" parameter placeholder ====== ====== PHP RFC: Escape PDO "?" parameter placeholder ======
-  * Version: 0.2+  * Version: 1.0
   * Date: 2019-05-31   * Date: 2019-05-31
   * Author: Matteo Beccati <mbeccati@php.net>   * Author: Matteo Beccati <mbeccati@php.net>
-  * Status: Draft+  * Status: Implemented
   * First Published at: http://wiki.php.net/rfc/pdo_escape_placeholders   * First Published at: http://wiki.php.net/rfc/pdo_escape_placeholders
 +  * Targets: PHP 7.4
  
 ===== Introduction ===== ===== Introduction =====
Line 51: Line 52:
  
 ==== Why not \? ==== ==== Why not \? ====
-That was my first idea, but backslash is the escaping symble for strings themselves, which was potentially making eventual escaping quite confusing: in order to send a backslash followed by a positional parameter placeholder one would have to write "\\\?" or "\\\\?", as "\\?" is in fact equivalent to "\?".+That was my first idea, but backslash is the escaping symbol for strings themselves, which was potentially making eventual escaping quite confusing: in order to send a backslash followed by a positional parameter placeholder one would have to write "\\\?" or "\\\\?", as "\\?" is in fact equivalent to "\?".
  
 ==== New PDO Flags ==== ==== New PDO Flags ====
Line 62: Line 63:
 Everything not PDO. Everything not PDO.
  
-===== Future Scope ===== +===== Vote ===== 
-This sections details areas where the feature might be improved in future, but that are not currently proposed in this RFC.+Started 7th July 2019Ends 22nd July 2019 
 +<doodle title="Add ?? as a way to escape ? in PDO parametrised queries?" auth="mbeccati" voteType="single" closed="true"> 
 +   * Yes 
 +   * No 
 +</doodle>
  
 ===== Proposed Voting Choices ===== ===== Proposed Voting Choices =====
Line 69: Line 74:
  
 ===== Patches and Tests ===== ===== Patches and Tests =====
-[[https://github.com/php/php-src/pull/1967]]+[[https://github.com/php/php-src/pull/4217]]
  
 ===== References ===== ===== References =====
-[[https://externals.io/thread/81#email-10436]]+  * [[https://bugs.php.net/bug.php?id=71885]] (Feature request) 
 +  * [[https://github.com/php/php-src/pull/1967]] (Original PR)
  
rfc/pdo_escape_placeholders.1559301013.txt.gz · Last modified: 2019/05/31 11:10 by mbeccati