rfc:number_format_negative_zero

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revisionPrevious revision
Next revision		Previous revision
rfc:number_format_negative_zero [2017/04/19 17:20] – Move to voting duncan3dcrfc:number_format_negative_zero [2018/03/01 23:24] (current) – RFC was implemented in PHP 7.2 carusogabriel
Line 4: Line 4:
   * Author: Craig Duncan <php@duncanc.co.uk>   * Author: Craig Duncan <php@duncanc.co.uk>
   * Proposed version: PHP 7.2   * Proposed version: PHP 7.2
-  * Status: Voting+  * Status: Implemented (in PHP 7.2)
  
 ===== Introduction ===== ===== Introduction =====
Line 34: Line 34:
 Simple Yes/No vote that doesn't change the language itself so requires 50% + 1 votes to get 'accepted'.  Simple Yes/No vote that doesn't change the language itself so requires 50% + 1 votes to get 'accepted'. 
  
-<doodle title="Prevent number_format() from returning negative zero" auth="duncan3dc" voteType="single" closed="false">+<doodle title="Prevent number_format() from returning negative zero" auth="duncan3dc" voteType="single" closed="true">
    * Yes    * Yes
    * No    * No
Line 41: Line 41:
 ===== Implementation ===== ===== Implementation =====
  
-Code change: +Pull request: 
-https://github.com/duncan3dc/php-src/commit/33d449099cdf87b78245eb967174fdb8743a8012 +https://github.com/php/php-src/pull/2508
- +
-New Test: +
-https://github.com/duncan3dc/php-src/commit/17eae90f4e122f099512b683bd6f1bfc996a46c4+
  
 =====References ===== =====References =====
rfc/number_format_negative_zero.1492622438.txt.gz · Last modified: 2017/09/22 13:28 (external edit)

Page Tools