rfc:multiple-catch

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revisionPrevious revision
Next revision		Previous revision
rfc:multiple-catch [2016/03/08 18:17] – pierrickrfc:multiple-catch [2017/09/22 13:28] (current) – external edit 127.0.0.1
Line 3: Line 3:
   * Date: 2016-03-06   * Date: 2016-03-06
   * Author: Pierrick Charron <pierrick@php.net>, Bronisław Białek <after89@gmail.com>   * Author: Pierrick Charron <pierrick@php.net>, Bronisław Białek <after89@gmail.com>
-  * Status: Draft+  * Status: Implemented (PHP 7.1)
   * First Published at: http://wiki.php.net/rfc/multiple-catch   * First Published at: http://wiki.php.net/rfc/multiple-catch
  
 ===== Introduction ===== ===== Introduction =====
  
-When two different types of exceptions are handled the same way, it is sometimes required to duplicate code of the catch statements.+When two different types of exceptions are handled the same way, it is sometimes required to duplicate the code of the ''catch'' statements.
  
-For exemple : +For example : 
  
 <code php> <code php>
Line 26: Line 26:
 </code> </code>
  
-A solution to fix this problem on the user level would be to implement a common interface for ExceptionType1 and ExceptionType2 and catch it. However, this is only possible when you control the exception hierarchy in your own code, but not possible when you don't control the code.+A solution to fix this problem on the user level would be to implement a common interface for ''ExceptionType1'' and ''ExceptionType2'' and catch it. However, this is only possible when you control the exception hierarchy in your own code, but not possible when you don't control the code.
  
 ===== Proposal ===== ===== Proposal =====
  
-This RFC introduce the possibility to catch multiple exceptions types in a single catch statement to avoid code duplication.+This RFC introduces the possibility to catch multiple exception types in a single ''catch'' statement to avoid code duplication.
  
 <code php> <code php>
Line 45: Line 45:
  
 This syntax and functionality is compatible with the Union types RFC proposed here : https://wiki.php.net/rfc/union_types This syntax and functionality is compatible with the Union types RFC proposed here : https://wiki.php.net/rfc/union_types
 +
 +==== When is it useful ? ====
 +
 +  * When a single method/function throw two different types of exceptions that you handle the same way;
 +  * When libraries are leaking their dependency's exceptions.
 +
  
 ===== Backward Incompatible Changes ===== ===== Backward Incompatible Changes =====
Line 63: Line 69:
 ==== To Opcache ==== ==== To Opcache ====
 None None
 +
 +==== To PHP tools/IDE ====
 +This change will require every PHP tools and IDE based on an AST parser to be modified to take this syntax change into account.
  
 ===== Links and Literature ===== ===== Links and Literature =====
Line 70: Line 79:
 Request on StackOverflow: http://stackoverflow.com/questions/8439581/catching-multiple-exception-types-in-one-catch-block Request on StackOverflow: http://stackoverflow.com/questions/8439581/catching-multiple-exception-types-in-one-catch-block
  
-===== Proposed Voting Choices ===== +===== Vote ===== 
-As this is a language change, a 2/3 majority is required. The vote is a straight Yes/No vote for accepting the RFC and merging the patch.+As this is a language change, a 2/3 majority is required. The vote is a straight Yes/No vote for accepting the RFC and merging the patch. Voting started on 2016-04-17 and will end on 2016-05-01. 
 + 
 +<doodle title="Should milti-catch be added to PHP 7.1" auth="pierrick" voteType="single" closed="true"> 
 +   * Yes 
 +   * No 
 +</doodle>
  
 ===== Patches and Tests ===== ===== Patches and Tests =====
  
-Patch : [[https://github.com/php/php-src/compare/master...adoy:multiple-catch]]+Patch : [[https://github.com/php/php-src/pull/1796/files]] 
 + 
 +===== Implementation ===== 
 + 
 +Merged into php-src for PHP 7.1: https://github.com/php/php-src/commit/0aed2cc2a440e7be17552cc669d71fdd24d1204a
  
rfc/multiple-catch.1457461068.txt.gz · Last modified: 2017/09/22 13:28 (external edit)

Page Tools