rfc:group_use_declarations

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revisionPrevious revision
Next revision		Previous revision
rfc:group_use_declarations [2015/02/01 13:35] – marciorfc:group_use_declarations [2017/09/22 13:28] (current) – external edit 127.0.0.1
Line 1: Line 1:
 ====== PHP RFC: Group Use Declarations ====== ====== PHP RFC: Group Use Declarations ======
 +  * Version: 0.4
   * Date: 2015-01-28   * Date: 2015-01-28
   * Author: Márcio Almada, marcio.web2@gmail.com   * Author: Márcio Almada, marcio.web2@gmail.com
-  * Status: Under Discussion+  * Status: Implemented (in PHP 7.0)
   * First Published at: http://wiki.php.net/rfc/group_use_declarations   * First Published at: http://wiki.php.net/rfc/group_use_declarations
   * Patch: https://github.com/php/php-src/pull/1005   * Patch: https://github.com/php/php-src/pull/1005
Line 23: Line 24:
  
 ===== Proposal ===== ===== Proposal =====
-Group use declarations are just **syntax sugar** to cut verbosity when importing multiple entities from a common namespace. Using common PHP library examples, the following use declarations are equivalents:+Group use declarations are used to cut verbosity when importing multiple entities from a common namespace. Using common PHP library examples, the following use declarations are equivalents:
  
 <code php> <code php>
Line 105: Line 106:
 ===== Justification ===== ===== Justification =====
  
-Group use statements makes it easier to identify that multiple imported entities are from the same module. For the first example in this RFC, instead of having to read 'FooLibrary\Bar\Baz\Biz' four times to see that the namespace is the same for each entry, it is clear by the grouping syntax that the entries all come from the same namespace.+Group use declaratations facilitates to import multiple structures from a common namespace and cuts a good level of verbosity in most cases. Group use declaratations makes it easier to identify that multiple imported entities belong to the same module.
  
-Also, group use statements makes it easier to see in patch diffs that a dependency on a new module has been introduced. For instance, a patch that adds a new dependency on "Consolidation" namespace has been introduced:+For the first example in this RFC, instead of having to read 'FooLibrary\Bar\Baz\Biz' four times to see that the namespace is the same for each entry, it is clear by the grouping syntax that the entries all come from the same namespace. 
 + 
 +The same advantage regardless readability is noticeable on patch diffs that a dependency on a new module has been introduced. For instance, a patch that adds a new dependency on "Consolidation" namespace has been introduced:
  
 <code> <code>
Line 117: Line 120:
 </code> </code>
  
-With the current use syntax it's necessary to read to the 30th character of the 2nd modified line to realise that the patch adds a new dependency. The proposed syntax is much more readable:+With the current use syntax it's necessary to read to the 30th character of the 2nd modified line to realize that the patch adds a new dependency. The proposed syntax is much more readable:
  
 <code> <code>
 use Symfony\Component\Console\Question\{ use Symfony\Component\Console\Question\{
     ConfirmationQuestion,     ConfirmationQuestion,
-    ChoiceQuestion as Choice;+    ChoiceQuestion as Choice,
 +   OptionQuestion, +   OptionQuestion,
     Question,     Question,
Line 129: Line 132:
 </code> </code>
  
 +==== Opinions ====
  
-===== About The Syntax Choice =====+This is a condensed list of unique reactions collected during email discussions and research phase: 
 + 
 +=== In Favor Or Partially Favorable === 
 + 
 +  * It's more readable and makes it easier to import classes, constants and functions in a concise way. 
 +  * It seems like a step in the right direction to improving namespaces and more closely approximating the better systems (like Python module imports). 
 +  * We really should have a shorthand for condensing use declarations. I wonder if the syntax could feel more "PHP" but maybe I'm just nitpicking. 
 +  * The benefits for users which are using IDEs seems marginal, but all other users could actually benefit from it so I'm in favor of the proposal. 
 +  * I would like to have it with the option for non enforced trailing "\" (T_NS_SEPARATOR) syntax. 
 +  * I'm in favor of the shorthand syntax but I don't care about the nesting option. 
 + 
 +=> Requests for a syntax variation without a trailing "\" were quite frequent and resulted in a voting [[group_use_declarations#options|option]].\\ 
 +=> Based on overall feedback the nested namespace option was removed. 
 + 
 +=== Contrary Or Indifferent === 
 + 
 +  * With proper tooling I almost can't remember when I wrote use statements "by hand" so I don't need it. 
 +  * The search for literal full qualified namespaces can become less straightforward. 
 + 
 +==== About The Syntax Choice ====
 The syntax chosen is inline with the current [[http://php.net/traits|trait adaptation]] syntax to make it look and feel similar to existing PHP standards. Such design choice allows the feature to stay familiar and intuitive to most PHP user base. The syntax chosen is inline with the current [[http://php.net/traits|trait adaptation]] syntax to make it look and feel similar to existing PHP standards. Such design choice allows the feature to stay familiar and intuitive to most PHP user base.
  
Line 136: Line 159:
  
 ==== Trailing T_NS_SEPARATOR ==== ==== Trailing T_NS_SEPARATOR ====
-During research phase a syntax variant **without** an enforced T_NS_SEPARATOR emerged as a debatable option:+During research phase a syntax variant **without** a trailing "\" (T_NS_SEPARATOR) emerged as a debatable option:
  
 <code php> <code php>
Line 149: Line 172:
 </code> </code>
  
-This shall be addressed on discussion phase: should a trailing "\" (T_NS_SEPARATOR) be enforced or removed from syntax?+This shall be addressed on voting phase: should a trailing "\" be enforced or removed from syntax?
  
-==== Nesting ==== +===== Proposed PHP Version(s) ===== 
-As the author of this RFC, I consider the **nesting** option **too complex** to be introduced. But since many people mentioned this **possibility**, it will be put into the discussion so the community has a chance to appoint.+This is proposed for the next PHP x, which at the time of this writing would be PHP 7. 
  
-**Nesting** would allow the following use case:+===== RFC Impact =====
  
-<code php> +=== On Functional Programming / Autoloading ===
-use Symfony\Component\Console\{ +
-  Helper\Table, +
-  Input\{ ArrayInput, InputInterface }, +
-  Output\{ NullOutput, OutputInterface }, +
-  Question\{ Question, ChoiceQuestion, ConfirmationQuestion } +
-}; +
-</code>+
  
-This shall be addressed on discussion phase: should nested group use declarations be allowed?+Group use declarations is also very helpful for the PHP user base more fond to the **functional** programming paradigms. This RFC would be especially important if PHP finally gets **function autoloading**.
  
 +Currently, sets of independent functions have to be implemented as static classes. But with function autoloading, they’d have to be imported independently, and that would lead to way too many use statements without this feature. Here is an example to illustrate this impact using the well known Nikita's [[https://github.com/nikic/iter|iter]] functional library:
  
-===== Backward Incompatible Changes ===== +<code php> 
-There is no BC breaks with current implementation or feature concepts.+// Current use syntax:
  
-===== Proposed PHP Version(s) ===== +use function iter\range; 
-This is proposed for the next PHP x, which at the time of this writing would be PHP 7. +use function iter\map; 
 +use function iter\filter; 
 +use function iter\apply; 
 +use function iter\reduce; 
 +use function iter\fn\operator;
  
-===== RFC Impact =====+// Proposed syntax: 
 + 
 +use function iter\{ range, map, filter, apply, reduce, fn\operator }; 
 + 
 +</code>
  
 === On Backward Compatibility === === On Backward Compatibility ===
 This RFC is backwards compatible with previous PHP releases. It's worth to add that the patch will **not** affect runtime performance. This RFC is backwards compatible with previous PHP releases. It's worth to add that the patch will **not** affect runtime performance.
- 
-===== Open Issues ===== 
-  * Should nested group use declarations be allowed? 
-  * Should trailing "\" (T_NS_SEPARATOR) be enforced or removed from syntax? 
  
 ===== Unaffected PHP Functionality ===== ===== Unaffected PHP Functionality =====
 Original namespace implementation is not affected by the addition of group use declarations. Current syntax would still be valid. Original namespace implementation is not affected by the addition of group use declarations. Current syntax would still be valid.
  
-===== Proposed Voting Choices ===== +===== Support in other languages ===== 
-As this RFC represents a language change a two third majority is required. +Other languages have similar ways to import multiple entities from a given package or module: 
 + 
 +  * [[http://www.rust-lang.org|Rust Language]] has a very similar syntax ''use a::b::{c, d, e, f};'' 
 +  * [[http://www.scala-lang.org/old/node/119|Scala]] has a very similar syntax ''use a.b.{c, d, e, f};'' 
 +  * [[https://www.python.org|Python]] has a different syntax but with the same objective: ''from fibo import fib, fib2, fib3'' 
 + 
 +===== Votes ===== 
 +As this is a language change, this RFC requires a 2/3 majority of Yes votes (with or without trailing "\") to pass. Voting started on 2015-02-11 and will end on 2015-02-25. 
 + 
 +<doodle title="Should Grouped Use Declarations be added to PHP 7" auth="marcio" voteType="single" closed="true"> 
 +   * Yes - **with** a trailing "\" 
 +   * Yes - **without** a trailing "\" 
 +   * No 
 +</doodle> 
 + 
 +===== Discussion in a Nutshell ===== 
 + 
 +In case you missed the discussion. This section lists the common counter points towards this RFC and how they were replied by the RFC author and supporters on mailing lists and media: 
 + 
 +==== My IDE already does the imports for me and folds the namespaces so I don't need this feature ==== 
 + 
 +We should create **usable languages by design** rather than **languages only usable by tooling**. Tooling can be very important 
 +but the moment you notice a stack of tools is needed to have a reasonable experience and readability with a programming language then something needs to be improved. 
 + 
 +A programming language should be able stand on its own and not require IDE assistance for reasonable use. That's what this RFC does, it brings a very common feature already available in many languages employing some kind of namespacing. 
 + 
 +==== The RFC encourages violation of the the SRP and other best practices ==== 
 + 
 +This is **not true**. Nikita already wrote a great response to this on the official PHP mailing list. Beware of the slay of good argumentation ahead: http://news.php.net/php.internals/82622 
 + 
 +==== We should have "first class packages" first, therefore we can't approve this RFC now! ==== 
 + 
 +This is painfully illogic. Group use declarations and "first class packages" are completely orthogonal features. Having group use declarations will only help to support long awaited features like "first class namespaces" or "function autoloading". The order in which the features are proposed or accepted is irrelevant in this case. We can **have** the feature **now**. 
 + 
 +Doing so **prior** to a major PHP7 **release** is, in fact, the **best hour** to **approve** this RFC. 
 + 
 +==== We should go for Python's syntax instead and reject this RFC ==== 
 + 
 +I doubt Python syntax will ever be proposed for PHP because it would require the the **from** keyword to be reserved, hence one of the reasons it was discarded during research and discussion. Other reason is that the glob brace syntax is more tailored for PHP and it is a [[https://wiki.php.net/rfc/group_use_declarations#support_in_other_languages|good choice]]. 
  
 ===== Patches and Tests ===== ===== Patches and Tests =====
 The implementation aims to be minimal and of easy maintenance. I created a PR so that the patch diff can be viewed easily: https://github.com/php/php-src/pull/1005 The implementation aims to be minimal and of easy maintenance. I created a PR so that the patch diff can be viewed easily: https://github.com/php/php-src/pull/1005
  
-The current initial implementation can be found on my PHP [[https://github.com/marcioAlmada/php-src/tree/group-use|fork]]. You can also directly contribute to this RFC by sending a pull request to https://github.com/marcioAlmada/RFCs.+The current implementation can be found on my PHP [[https://github.com/marcioAlmada/php-src/tree/group-use|fork]]. You can also directly contribute to this RFC by sending a pull request to https://github.com/marcioAlmada/RFCs.
  
 ===== References ===== ===== References =====
 There is no found record related to group use declarations on mailing lists. There is no found record related to group use declarations on mailing lists.
  
-==== Support in other languages ==== +===== Changelog ===== 
-Other languages have similar ways to import multiple entities from a given package or module:+ 
 +  * 0.1 - first proposal 
 +  * 0.2 - added trailing "\" syntax to proposal 
 +  * 0.3 - added voting option for a non trailing "\" syntax 
 +  * 0.4 - RFC was simplified: "nesting" voting option was removed 
 + 
 +===== Acknowledgements =====
  
-  * [[http://www.rust-lang.org|Rust Language]] has a very similar sintax `use a::b::{c, d, e, f};` +Thanks to:
-  * [[http://www.scala-lang.org/old/node/119|Scala]] has a very similar sintax `use a.b.{c, d, e, f};` +
-  * [[https://www.python.org|Pyhon]] has a different syntax but with the same objective: `from fibo import fib, fib2, fib3`+
  
-===== Rejected Features ===== +  - Daniel Ackroyd for reviewing this RFC. 
-Awaiting discussion.+  - Andrea and Rangad for their insightful opinions. 
 +  - NikiC for providing accurate information about the PHP implementation. 
 +  - All people on http://chat.stackoverflow.com/rooms/11/php
  
rfc/group_use_declarations.1422797717.txt.gz · Last modified: 2017/09/22 13:28 (external edit)

Page Tools