Differences

This shows you the differences between two versions of the page.

--- rfc:error-optimizations [2010/08/24 15:18] – kalle
+++ rfc:error-optimizations [2017/09/22 13:28] (current) – external edit 127.0.0.1
@@ Line 3: / Line 3: @@
   * Date: 2010-08-21
   * Author: Kalle Sommer Nielsen <kalle@php.net>
-  * Status: In the works
+  * Status: Draft (Inactive)
   * First Published at: http://wiki.php.net/rfc/error-optimizations
@@ Line 97: / Line 97: @@
 Obvious the memory usage here can grow quite rapidly, but people who would use this feature already takes great care of their code to not assume the opposite.
-===== Additional notes =====
+==== ZTS performance ====
-  * While altering the internal logic of zend_error() and zend_error_cb() to match that of the above, it might be worth passing the TSRMLS macros to it, to save some TS performance at every call, which itself is a bonus for multithreaded SAPIs.
+Since the error stack is hooked into the executor globals, which requires tsrm_ls to be available in thread safety mode, to avoid a call to TSRMLS_FETCH() everytime we hit the error callbacks or functions (zend_error, zend_error_cb, ...) then we should alter all references to include TSRMLS_DC/TSRMLS_CC for additional performance with ZTS.