rfc:dom_living_standard_api

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revisionPrevious revision
Next revision
Previous revision
rfc:dom_living_standard_api [2019/10/11 15:14] – Fix nullable syntax, thanks Chuck beberleirfc:dom_living_standard_api [2020/08/01 23:39] (current) – RFC was implemented carusogabriel
Line 4: Line 4:
   * Date: 2019-09-15   * Date: 2019-09-15
   * Author: Benjamin Eberlei (beberlei@php.net), Thomas Weinert    * Author: Benjamin Eberlei (beberlei@php.net), Thomas Weinert 
-  * Status: Under Discussion+  * Status: Implemented
   * First Published at: http://wiki.php.net/rfc/dom_living_standard_api   * First Published at: http://wiki.php.net/rfc/dom_living_standard_api
  
Line 32: Line 32:
 { {
     /** access to the first child of this node that is a DOMElement */     /** access to the first child of this node that is a DOMElement */
-    public readonly ?DOMNode $firstElementChild;+    public readonly ?DOMElement $firstElementChild;
        
     /** access to the last child of this node that is a DOMElement */     /** access to the last child of this node that is a DOMElement */
-    public readonly ?DOMNode $lastElementChild;+    public readonly ?DOMElement $lastElementChild;
          
     /** counts all child nodes that are DOMElements */     /** counts all child nodes that are DOMElements */
Line 54: Line 54:
 { {
     /** Returns the previous node in the same hierachy that is a DOMElement or NULL if there is none */     /** Returns the previous node in the same hierachy that is a DOMElement or NULL if there is none */
-    public readonly ?DOMNode $previousElementSibling;+    public readonly ?DOMElement $previousElementSibling;
        
     /** Returns the next node in the same hierachy that is a DOMElement or NULL if there is none */      /** Returns the next node in the same hierachy that is a DOMElement or NULL if there is none */ 
-    public readonly ?DOMNode $nextElementSibling;+    public readonly ?DOMElement $nextElementSibling;
  
     /** acts as a simpler version of $element->parentNode->removeChild($element); */     /** acts as a simpler version of $element->parentNode->removeChild($element); */
Line 144: Line 144:
 https://github.com/php/php-src/pull/4709 https://github.com/php/php-src/pull/4709
  
-This pull request is still work in progress+The pull request is mostly finished and only refactorings need to be done.
  
-===== Implementation =====+===== Vote ======
  
-tbd+Voting requires 2/3 majority and closes on 25th November 2019 UTC 23:59:59 
 + 
 +<doodle title="Accept changes to DOM API to add support for new methods added in WHATWG groups DOM living standard?" auth="beberlei" voteType="single" closed="true"> 
 +   * Yes 
 +   * No 
 +</doodle>
  
 ===== References ===== ===== References =====
rfc/dom_living_standard_api.1570806877.txt.gz · Last modified: 2019/10/11 15:14 by beberlei