rfc:counting_non_countables

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revisionPrevious revision
Next revision		Previous revision
rfc:counting_non_countables [2016/10/21 18:50] – Example fixup duncan3dcrfc:counting_non_countables [2018/03/01 23:26] (current) – RFC was implemented in PHP 7.2 carusogabriel
Line 2: Line 2:
   * Version: 0.4   * Version: 0.4
   * Date: 2016-10-04   * Date: 2016-10-04
-  * Author: Craig Duncan <git@duncanc.co.uk>+  * Author: Craig Duncan <php@duncanc.co.uk>
   * Proposed version: PHP 7.2   * Proposed version: PHP 7.2
-  * Status: Voting+  * Status: Implemented (in PHP 7.2)
   * ML thread: http://externals.io/thread/350   * ML thread: http://externals.io/thread/350
  
Line 47: Line 47:
 ===== Vote ===== ===== Vote =====
  
-<doodle title="Counting of non-countable objects" auth="duncan3dc" voteType="single" closed="false">+<doodle title="Counting of non-countable objects" auth="duncan3dc" voteType="single" closed="true">
    * Yes    * Yes
    * No    * No
 </doodle> </doodle>
  
-===== Patches and Tests =====+===== Implementation =====
  
-Patch to handle the change: +Pull request to handle the change: 
-https://github.com/duncan3dc/php-src/commit/ea03689a800dfeb0b94b0b7a2a0ed837c280f27f +https://github.com/php/php-src/pull/2185
- +
-Example tests: +
-https://github.com/duncan3dc/php-src/commit/3e4fa60b63c94a7015d09f7310e6653ece86db05+
  
 =====References ===== =====References =====
Line 64: Line 61:
 Initial discussion that led to this RFC's creation: Initial discussion that led to this RFC's creation:
 https://github.com/php/php-src/pull/1672 https://github.com/php/php-src/pull/1672
 +
 +Discussion thread:
 +http://externals.io/thread/350
 +
 +Voting thread:
 +http://externals.io/thread/409
  
rfc/counting_non_countables.1477075835.txt.gz · Last modified: 2017/09/22 13:28 (external edit)

Page Tools