internals:review_comments

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revision Previous revision
Next revision
Previous revision
internals:review_comments [2013/10/14 13:45]
ab new section about PECL checks
internals:review_comments [2017/09/22 13:28] (current)
Line 1: Line 1:
 +===== Common comments from reviewing PECL proposals =====
 +
 While reviewing PECL proposals there are some common issues which can be observed. This page collects some of those to provide extended information and saving reviewers from explaining those multiple times. This is different from other sections on this wiki a it focusses on review perspective. While reviewing PECL proposals there are some common issues which can be observed. This page collects some of those to provide extended information and saving reviewers from explaining those multiple times. This is different from other sections on this wiki a it focusses on review perspective.
  
Line 153: Line 155:
 . for version string compliance in package.xml and the extension source code. The following should be defined in one of the extension header files . for version string compliance in package.xml and the extension source code. The following should be defined in one of the extension header files
  
-  #define PHP_FOO_VERSION "1.2.3"+  #define PHP_EXTNAME_VERSION "1.2.3"
  
-This macros has to be used within your extname_module_entry to indicate the extension version.+This macros has to be used within your extname_module_entry to indicate the extension version. The version string in both package.xml and the defined macros have to match. The work of adding that macros could be already done when using ext_skel on PHP versions as of 5.4.21 or 5.5.5.
internals/review_comments.1381758325.txt.gz · Last modified: 2017/09/22 13:28 (external edit)