internals:review_comments

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

Both sides previous revisionPrevious revision
Next revision
Previous revision
Next revisionBoth sides next revision
internals:review_comments [2013/01/09 11:17] – notes on C99 johannesinternals:review_comments [2013/10/14 13:45] – new section about PECL checks ab
Line 135: Line 135:
     NULL,     NULL,
     PHP_MINFO(myext),     PHP_MINFO(myext),
-    MYEXT_VERSION,+    PHP_MYEXT_VERSION,
     STANDARD_MODULE_PROPERTIES     STANDARD_MODULE_PROPERTIES
   };   };
Line 142: Line 142:
  
 Also see the previous item. Also see the previous item.
 +
 +====== PECL site conformity ======
 +
 +A few conformity checks are done on the tarball upload, the PECL site will check for
 +
 +. presence of LICENSE or COPYING in the package.xml, add it to the root dir with the line like this
 +  
 +  <file name="LICENSE" role="doc" />
 +
 +. for version string compliance in package.xml and the extension source code. The following should be defined in one of the extension header files
 +
 +  #define PHP_FOO_VERSION "1.2.3"
 +
 +This macros has to be used within your extname_module_entry to indicate the extension version.
internals/review_comments.txt · Last modified: 2017/09/22 13:28 by 127.0.0.1